How to provide a patch?

[jl...@cohesionforce.com]

Hi,

I've done a bit of work that I'm using on a program where I have added  
Snappy compression support to the C++ DataFile class.  I also added a  
unit test to test the changes.

I would like to make this available to the Avro community, but I don't  
know how to do that.  Also - I'm not familiar with the CMake process  
for adding Snappy as a dependency, so that part would probably need to  
be redone.

Is this as easy as running some kind of patch script to create  
something from Subversion?

Thanks,
-J. Langley

Re: How to provide a patch?

[jl...@cohesionforce.com]

Thanks Sean!

I gave it a shot with a git pull request on Avro Issue 1748.  It was  
pretty straightforward, but I had to go back and "unformat" a file  
that my editor had murdered with whitespace changes.  Now it should be  
pretty clear where the changes were made.

Thanks,
-J.

Quoting Sean Busbey <bu...@cloudera.com>:

> Hi!
>
> Glad to hear you'er interested in contributing back to the community.
> Adding snappy to the C++ library sounds great.
>
> Here's a link to the full guide on contributing:
>
> https://cwiki.apache.org/confluence/display/AVRO/How+To+Contribute
>
> It's pretty thorough, so here's a short version:
>
> 1) create an issue in our JIRA tracker:
>
> http://issues.apache.org/jira/browse/AVRO
>
> It should be listed as either 'improvement' or 'new feature.'
>
> 2) create a patch
>
> You can do this off of subversion, as you mention, and attach to the jira
> you made. Alternatively, if it's easier for you we also accept pull
> requests against the github mirror of our project:
>
> https://github.com/apache/avro
>
> I look forward to helping review your contribution. Please let us know if
> you have any other questions.
>
> --
> Sean
> On Oct 10, 2015 12:04 PM, <jl...@cohesionforce.com> wrote:
>
>> Hi,
>>
>> I've done a bit of work that I'm using on a program where I have added
>> Snappy compression support to the C++ DataFile class.  I also added a unit
>> test to test the changes.
>>
>> I would like to make this available to the Avro community, but I don't
>> know how to do that.  Also - I'm not familiar with the CMake process for
>> adding Snappy as a dependency, so that part would probably need to be
>> redone.
>>
>> Is this as easy as running some kind of patch script to create something
>> from Subversion?
>>
>> Thanks,
>> -J. Langley
>>
>>
>>

Re: How to provide a patch?

[Sean Busbey <bu...@cloudera.com>]

Hi!

Glad to hear you'er interested in contributing back to the community.
Adding snappy to the C++ library sounds great.

Here's a link to the full guide on contributing:

https://cwiki.apache.org/confluence/display/AVRO/How+To+Contribute

It's pretty thorough, so here's a short version:

1) create an issue in our JIRA tracker:

http://issues.apache.org/jira/browse/AVRO

It should be listed as either 'improvement' or 'new feature.'

2) create a patch

You can do this off of subversion, as you mention, and attach to the jira
you made. Alternatively, if it's easier for you we also accept pull
requests against the github mirror of our project:

https://github.com/apache/avro

I look forward to helping review your contribution. Please let us know if
you have any other questions.

-- 
Sean
On Oct 10, 2015 12:04 PM, <jl...@cohesionforce.com> wrote:

> Hi,
>
> I've done a bit of work that I'm using on a program where I have added
> Snappy compression support to the C++ DataFile class.  I also added a unit
> test to test the changes.
>
> I would like to make this available to the Avro community, but I don't
> know how to do that.  Also - I'm not familiar with the CMake process for
> adding Snappy as a dependency, so that part would probably need to be
> redone.
>
> Is this as easy as running some kind of patch script to create something
> from Subversion?
>
> Thanks,
> -J. Langley
>
>
>