You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/11/28 17:53:00 UTC
Re: Review Request 53759: CMake: Change libprocess to a shared
library.
> On Nov. 17, 2016, 5:09 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/src/CMakeLists.txt, line 93
> > <https://reviews.apache.org/r/53759/diff/1/?file=1563860#file1563860line93>
> >
> > Seems like this should be using `MESOS_DEFAULT_LIBRARY_LINKAGE`?
>
> Joseph Wu wrote:
> Nope, Mesos variables shouldn't be used in stout/libprocess.
Right. I suppose my real question is: should this be a variable of some sort? It seems odd we'd use one elsewhere, but not for Stout.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53759/#review156214
-----------------------------------------------------------
On Nov. 15, 2016, 3:09 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53759/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2016, 3:09 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
>
>
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to load modules that are themselves based on libprocess,
> we must link libprocess as a shared library. Since modules are
> only supported on non-Windows platforms, this changes the default
> linking mode to SHARED on non-Windows.
>
> This review replaces: https://reviews.apache.org/r/49924/
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/CMakeLists.txt d1547ef6a8762385f653d3824307727e4d0a7e71
>
> Diff: https://reviews.apache.org/r/53759/diff/
>
>
> Testing
> -------
>
> cmake ..
> make
>
>
> Thanks,
>
> Joseph Wu
>
>