You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2022/02/14 03:30:03 UTC

[GitHub] [parquet-mr] sekikn opened a new pull request #947: PARQUET-2121: Remove descriptions for the removed modules

sekikn opened a new pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-2121
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   No additional test since it's just a documentation fix.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1054543248


   The only comment left is in the .gitignore file. Question is should we remove 'parquet-scrooge/.cache'? If the code for parquet-scrooge is still there, there may be needed to keep it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1039353753


   @sekikn Thanks for working on it! Just leave some minor comments. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] sekikn commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1053807442


   @shangxinli I'm afraid I can see just one comment at L69 of README.md...
   Would you point to the comment left with a permalink or something? Maybe I don't understand GitHub's functionality or missed something.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] sekikn commented on a change in pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
sekikn commented on a change in pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947#discussion_r806426714



##########
File path: README.md
##########
@@ -66,10 +66,8 @@ Parquet is a very active project, and new features are being added quickly. Here
 * Type-specific encoding
 * Hive integration (deprecated)
 * Pig integration
-* Cascading integration

Review comment:
       Thank you for the comment, @shangxinli! I updated the PR.
   Instead of removing the lines, I just added '(deprecated)' to parquet-cascading* and parquet-scrooge in README.md, just like parquet-hive.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli merged pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
shangxinli merged pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
shangxinli commented on a change in pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947#discussion_r806064746



##########
File path: README.md
##########
@@ -66,10 +66,8 @@ Parquet is a very active project, and new features are being added quickly. Here
 * Type-specific encoding
 * Hive integration (deprecated)
 * Pig integration
-* Cascading integration

Review comment:
       Since the code is still there, do you think we can just add '(deprecated)' here/

##########
File path: README.md
##########
@@ -66,10 +66,8 @@ Parquet is a very active project, and new features are being added quickly. Here
 * Type-specific encoding
 * Hive integration (deprecated)
 * Pig integration
-* Cascading integration

Review comment:
       Since the code is still there, do you think we can just add '(deprecated)' here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1039353753


   @sekikn Thanks for working on it! Just leave some minor comments. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] sekikn commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1054795653


   Thank you for the elaboration, @shangxinli!
   Let me confirm, I think the parquet-cascading* and parquet-scrooge directories were removed on the master branch in #888.
   In addition, they had been renamed to "*-deprecated" before the removal, so the line in .gitignore in question has no effect.
   So I'm not sure what "the code is still there" you mentioned means... Is my understanding correct?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on a change in pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
shangxinli commented on a change in pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947#discussion_r806064746



##########
File path: README.md
##########
@@ -66,10 +66,8 @@ Parquet is a very active project, and new features are being added quickly. Here
 * Type-specific encoding
 * Hive integration (deprecated)
 * Pig integration
-* Cascading integration

Review comment:
       Since the code is still there, do you think we can just add '(deprecated)' here/

##########
File path: README.md
##########
@@ -66,10 +66,8 @@ Parquet is a very active project, and new features are being added quickly. Here
 * Type-specific encoding
 * Hive integration (deprecated)
 * Pig integration
-* Cascading integration

Review comment:
       Since the code is still there, do you think we can just add '(deprecated)' here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1050466476


   Thanks for addressing the comments! There is one left over. After that, I think we can merge it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] shangxinli commented on pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947#issuecomment-1059353244


   > Thank you for the elaboration, @shangxinli! Let me confirm, I think the parquet-cascading* and parquet-scrooge directories were removed on the master branch in #888. In addition, they had been renamed to "*-deprecated" before the removal, so the line in .gitignore in question has no effect. So I'm not sure what "the code is still there" you mentioned means... Is my understanding correct?
   
   Thanks @sekikn for checking! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [parquet-mr] sekikn commented on a change in pull request #947: PARQUET-2121: Remove descriptions for the removed modules

Posted by GitBox <gi...@apache.org>.
sekikn commented on a change in pull request #947:
URL: https://github.com/apache/parquet-mr/pull/947#discussion_r806426714



##########
File path: README.md
##########
@@ -66,10 +66,8 @@ Parquet is a very active project, and new features are being added quickly. Here
 * Type-specific encoding
 * Hive integration (deprecated)
 * Pig integration
-* Cascading integration

Review comment:
       Thank you for the comment, @shangxinli! I updated the PR.
   Instead of removing the lines, I just added '(deprecated)' to parquet-cascading* and parquet-scrooge in README.md, just like parquet-hive.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org