You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/03/27 19:48:24 UTC

Review Request 19741: Added style checker to verify-reviews.py.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19741/
-----------------------------------------------------------

Review request for mesos and Dominic Hamon.


Bugs: MESOS-1151
    https://issues.apache.org/jira/browse/MESOS-1151


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  support/mesos-style.py 084690a207baa5d5f8f9273f10c67a642371908e 
  support/verify-reviews.py 2ee777f8a1d21afdbf11c31f04a3d9d4d869a330 

Diff: https://reviews.apache.org/r/19741/diff/


Testing
-------

Tested mesos-style.py manually.


Thanks,

Vinod Kone

Re: Review Request 19741: Added style checker to verify-reviews.py.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19741/#review38786
-----------------------------------------------------------

Ship it!


Ship It!


support/verify-reviews.py
<https://reviews.apache.org/r/19741/#comment71073>

    could you add a TODO to only check the files in the patch?


- Dominic Hamon


On March 27, 2014, 11:48 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19741/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 11:48 a.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Bugs: MESOS-1151
>     https://issues.apache.org/jira/browse/MESOS-1151
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py 084690a207baa5d5f8f9273f10c67a642371908e 
>   support/verify-reviews.py 2ee777f8a1d21afdbf11c31f04a3d9d4d869a330 
> 
> Diff: https://reviews.apache.org/r/19741/diff/
> 
> 
> Testing
> -------
> 
> Tested mesos-style.py manually.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>