[lucene-solr] 43/49: @557 Remove System.outs.

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git

commit 8603f04eea0a369a250b05928723ae130020efde
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Sun Aug 16 20:30:44 2020 -0500

    @557 Remove System.outs.
---
 .../apache/solr/cloud/api/collections/CreateCollectionCmd.java    | 8 --------
 .../java/org/apache/solr/handler/component/HttpShardHandler.java  | 1 -
 solr/core/src/java/org/apache/solr/update/IndexFingerprint.java   | 1 -
 .../apache/solr/update/processor/DistributedUpdateProcessor.java  | 3 ---
 4 files changed, 13 deletions(-)

diff --git a/solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java b/solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
index 73e41e9..a2450dc 100644
--- a/solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
+++ b/solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
@@ -348,10 +348,6 @@ public class CreateCollectionCmd implements OverseerCollectionMessageHandler.Cmd
               sreq.params.set(CoreAdminParams.CORE_NODE_NAME, coreNodeName);
               log.info("Set the {} for replica {} to {}", CoreAdminParams.CORE_NODE_NAME, replica, coreNodeName);
             }
-            if (sreq.params.get(CoreAdminParams.CORE_NODE_NAME) == null) {
-              System.out.println(replicas);
-              System.out.println(coresToCreate);
-            }
            
             log.info("Submit request to shard for for replica={}", sreq.actualShards != null ? Arrays.asList(sreq.actualShards) : "null");
             shardHandler.submit(sreq, sreq.shards[0], sreq.params);
@@ -815,11 +811,9 @@ public class CreateCollectionCmd implements OverseerCollectionMessageHandler.Cmd
     return (liveNodes, collectionState) -> {
     //  log.info("Updated state {}", collectionState);
       if (collectionState == null) {
-         System.out.println("coll is null");
         return false;
       }
       if (collectionState.getSlices() == null) {
-        System.out.println("slices is null");
         return false;
       }
 
@@ -831,10 +825,8 @@ public class CreateCollectionCmd implements OverseerCollectionMessageHandler.Cmd
         }
       }
       if (replicas == expectedReplicas) {
-        System.out.println("found replicas  " + expectedReplicas + " " + replicas);
         return true;
       }
-      System.out.println("replica count is  " + expectedReplicas + " " + replicas);
       return false;
     };
   }
diff --git a/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java b/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java
index 0f2c65b..23f71d8 100644
--- a/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java
+++ b/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java
@@ -351,7 +351,6 @@ public class HttpShardHandler extends ShardHandler {
   private ShardResponse take(boolean bailOnError) {
     if (HttpShardHandlerFactory.ASYNC) {
       while (asyncPending.size() > 0) {
-        System.out.println("take");
         ShardResponse srsp = asyncPending.iterator().next();
         assert srsp != null;
         asyncPending.remove(srsp);
diff --git a/solr/core/src/java/org/apache/solr/update/IndexFingerprint.java b/solr/core/src/java/org/apache/solr/update/IndexFingerprint.java
index a2e173c..67503e4 100644
--- a/solr/core/src/java/org/apache/solr/update/IndexFingerprint.java
+++ b/solr/core/src/java/org/apache/solr/update/IndexFingerprint.java
@@ -132,7 +132,6 @@ public class IndexFingerprint implements MapSerializable {
         f.numVersions++;
       }
     }
-    System.out.println("Create new fingerprint:" + f);
     return f;
   }
 
diff --git a/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java b/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
index 2559e32..77d6de6 100644
--- a/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
+++ b/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java
@@ -455,10 +455,8 @@ public class DistributedUpdateProcessor extends UpdateRequestProcessor {
               // specified it must exist (versionOnUpdate==1) and it does.
             } else {
               if(cmd.getReq().getParams().getBool(CommonParams.FAIL_ON_VERSION_CONFLICTS, true) == false) {
-                System.out.println("version conflict! DROP!");
                 return true;
               }
-              System.out.println("version conflict!");
               throw new SolrException(ErrorCode.CONFLICT, "version conflict for " + cmd.getPrintableId()
                   + " expected=" + versionOnUpdate + " actual=" + foundVersion);
             }
@@ -476,7 +474,6 @@ public class DistributedUpdateProcessor extends UpdateRequestProcessor {
             // we're not in an active state, and this update isn't from a replay, so buffer it.
             cmd.setFlags(cmd.getFlags() | UpdateCommand.BUFFERING);
             ulog.add(cmd);
-            System.out.println(" we're not in an active state, and this update isn't from a replay, so buffer it.");
             return true;
           }