You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/26 08:01:11 UTC
[GitHub] [dolphinscheduler] caishunfeng opened a new pull request, #12146: [3.1.0-prepare] Update version to 310
caishunfeng opened a new pull request, #12146:
URL: https://github.com/apache/dolphinscheduler/pull/12146
Update version to 310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #12146: [3.1.0-prepare] Update version to 310
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #12146:
URL: https://github.com/apache/dolphinscheduler/pull/12146#discussion_r979708629
##########
docs/configs/docs3-1-0.js:
##########
@@ -25,19 +25,19 @@ export default {
children: [
{
title: 'Introduction',
- link: '/en-us/docs/dev/user_doc/about/introduction.html',
+ link: '/en-us/docs/3.1.0/user_doc/about/introduction.html',
Review Comment:
you should keep the document in the old name, `docsdev.js`, it will auto change the file name during the sync process in `dolphinscheudler-website` repo, see more detail in https://github.com/apache/dolphinscheduler-website/blob/master/scripts/rsync_content.sh#L109
##########
docs/docs/en/history-versions.md:
##########
@@ -4,6 +4,10 @@
#### Setup instructions, are available for each stable version of Apache DolphinScheduler below:
+### Versions: 3.1.0
+
+#### Links： [3.1.0 文档](../3.1.0/user_doc/about/introduction.md)
Review Comment:
```suggestion
#### Links： [3.1.0 Document](../3.1.0/user_doc/about/introduction.md)
```
##########
docs/configs/site.js:
##########
@@ -45,7 +45,7 @@ export default {
children: [
{
key: 'docs0',
- text: 'latest(3.0.0)',
+ text: 'latest(3.1.0)',
Review Comment:
we should merge #12139 and show version 3.0.1 and 3.1.0 both in our website
##########
docs/configs/site.js:
##########
@@ -45,7 +45,7 @@ export default {
children: [
{
key: 'docs0',
- text: 'latest(3.0.0)',
+ text: 'latest(3.1.0)',
Review Comment:
And there is one more thing here, if we merge this patch, the website will show the version 3.1.0 document, but we have three days for the ASF vote process.
But other change should be before the voting process, so our doc show we should separate into two PR instead of a single one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #12146: [3.1.0-prepare] Update version to 310
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #12146:
URL: https://github.com/apache/dolphinscheduler/pull/12146#discussion_r979717851
##########
docs/configs/site.js:
##########
@@ -45,7 +45,7 @@ export default {
children: [
{
key: 'docs0',
- text: 'latest(3.0.0)',
+ text: 'latest(3.1.0)',
Review Comment:
I think we should better show both version 3.0.1 and 3.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12146: [3.1.0-prepare] Update version to 310
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12146:
URL: https://github.com/apache/dolphinscheduler/pull/12146#issuecomment-1257873456
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12146)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=BUG) [5 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=VULNERABILITY) [3 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=CODE_SMELL) [48 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12146&metric=new_coverage&view=list) [41.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12146&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12146&metric=new_duplicated_lines_density&view=list) [3.5% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12146&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #12146: [3.1.0-prepare] Update version to 310
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #12146:
URL: https://github.com/apache/dolphinscheduler/pull/12146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #12146: [3.1.0-prepare] Update version to 310
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #12146:
URL: https://github.com/apache/dolphinscheduler/pull/12146#issuecomment-1257868510
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=12146)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=BUG) [5 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=VULNERABILITY) [3 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=CODE_SMELL) [48 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=12146&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12146&metric=new_coverage&view=list) [41.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12146&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12146&metric=new_duplicated_lines_density&view=list) [3.5% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=12146&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #12146: [3.1.0-prepare] Update version to 310
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #12146:
URL: https://github.com/apache/dolphinscheduler/pull/12146#discussion_r979719397
##########
docs/configs/site.js:
##########
@@ -45,7 +45,7 @@ export default {
children: [
{
key: 'docs0',
- text: 'latest(3.0.0)',
+ text: 'latest(3.1.0)',
Review Comment:
> And there is one more thing here, if we merge this patch, the website will show the version 3.1.0 document, but we have three days for the ASF vote process.
> But other change should be before the voting process, so our doc show we should separate into two PR instead of a single one
I find out that your target branch is `3.1.0-prepare`, but this change should be in dev branch
<img width="878" alt="image" src="https://user-images.githubusercontent.com/15820530/192230537-57db9e10-474f-4bc3-9533-49ac633bf4b3.png">, according to https://dolphinscheduler.apache.org/en-us/docs/dev/user_doc/contribute/release/release.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12146: [3.1.0-prepare] Update version to 310
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #12146:
URL: https://github.com/apache/dolphinscheduler/pull/12146#discussion_r979759954
##########
docs/configs/docs3-1-0.js:
##########
@@ -25,19 +25,19 @@ export default {
children: [
{
title: 'Introduction',
- link: '/en-us/docs/dev/user_doc/about/introduction.html',
+ link: '/en-us/docs/3.1.0/user_doc/about/introduction.html',
Review Comment:
I have restored the filename
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12146: [3.1.0-prepare] Update version to 310
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #12146:
URL: https://github.com/apache/dolphinscheduler/pull/12146#discussion_r979689664
##########
docs/configs/site.js:
##########
@@ -45,7 +45,7 @@ export default {
children: [
{
key: 'docs0',
- text: 'latest(3.0.0)',
+ text: 'latest(3.1.0)',
Review Comment:
I'm not sure is it OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12146: [3.1.0-prepare] Update version to 310
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #12146:
URL: https://github.com/apache/dolphinscheduler/pull/12146#discussion_r979760286
##########
docs/configs/site.js:
##########
@@ -45,7 +45,7 @@ export default {
children: [
{
key: 'docs0',
- text: 'latest(3.0.0)',
+ text: 'latest(3.1.0)',
Review Comment:
Have restored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org