You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/06/09 07:16:35 UTC
[PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
kou opened a new pull request, #46741:
URL: https://github.com/apache/arrow/pull/46741
### Rationale for this change
Apache Thrift 0.22.0 has been released: https://github.com/apache/thrift/releases/tag/v0.22.0
### What changes are included in this PR?
Update bundled Thrift version.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46741:
URL: https://github.com/apache/arrow/pull/46741#issuecomment-3003928419
`std::iterator` is a warning not an error. So it's not a blocker of this. We can use Thrift 0.22.0 (that doesn't include the changes for `std::iterator`).
`boost/uuid` is a blocker because our CMake configuration for Boost doesn't find `boost/uuid`.
(Sorry, not working on this yet...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46741:
URL: https://github.com/apache/arrow/pull/46741#issuecomment-2955071709
Hmm...
https://github.com/ursacomputing/crossbow/actions/runs/15529087541/job/43714065005#step:3:1300
```text
-- stderr output is:
In file included from /build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/TApplicationException.h:23,
from /build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/TApplicationException.cpp:20:
/build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/Thrift.h:54:19: warning: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Wdeprecated-declarations]
54 | : public std::iterator<std::forward_iterator_tag, std::pair<int, const char*> > {
| ^~~~~~~~
In file included from /usr/include/c++/13/bits/stl_iterator_base_funcs.h:66,
from /usr/include/c++/13/string:47,
from /build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/Thrift.h:37:
/usr/include/c++/13/bits/stl_iterator_base_types.h:127:34: note: declared here
127 | struct _GLIBCXX17_DEPRECATED iterator
| ^~~~~~~~
In file included from /build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/TOutput.cpp:20:
/build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/Thrift.h:54:19: warning: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Wdeprecated-declarations]
54 | : public std::iterator<std::forward_iterator_tag, std::pair<int, const char*> > {
| ^~~~~~~~
In file included from /usr/include/c++/13/bits/stl_iterator_base_funcs.h:66,
from /usr/include/c++/13/string:47,
from /build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/Thrift.h:37:
/usr/include/c++/13/bits/stl_iterator_base_types.h:127:34: note: declared here
127 | struct _GLIBCXX17_DEPRECATED iterator
| ^~~~~~~~
/build/arrow/thrift_ep-prefix/src/thrift_ep/lib/cpp/src/thrift/TUuid.cpp:22:10: fatal error: boost/uuid/string_generator.hpp: No such file or directory
22 | #include <boost/uuid/string_generator.hpp>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #46741:
URL: https://github.com/apache/arrow/pull/46741#issuecomment-3003864522
> @kou are we waiting for a 0.23.0 (or 0.22.1) version of Thrift? or should we apply the upstream patches that have been merged? Updating the version might fix the flaky issues we get downloading old Thrift.
I think we can definitely wait for a fixed Thrift release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #46741:
URL: https://github.com/apache/arrow/pull/46741#issuecomment-2987454484
@kou are we waiting for a 0.23.0 (or 0.22.1) version of Thrift? or should we apply the upstream patches that have been merged? Updating the version might fix the flaky issues we get downloading old Thrift.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46741:
URL: https://github.com/apache/arrow/pull/46741#issuecomment-2954913925
Revision: 22e86621bb7fe4f2b40678db9e9d121616a5b111
Submitted crossbow builds: [ursacomputing/crossbow @ actions-e66c94ae55](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e66c94ae55)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087746/job/43714065417)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087584/job/43714064664)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087541/job/43714065005)|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088916/job/43714075705)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089221/job/43714076250)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089424/job/43714076537)|
|r-recheck-most|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087531/job/43714066041)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088294/job/43714068923)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088709/job/43714073428)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087290/job/43714063531)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088516/job/43714073028)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088217/job/43714068629)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088248/job/43714068619)|
|test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088134/job/43714067208)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087090/job/43714062900)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087972/job/43714066508)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088129/job/43714067022)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087393/job/43714063567)|
|test-conda-python-3.11-pandas-latest-numpy-1.26|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089107/job/43714076244)|
|test-conda-python-3.11-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089388/job/43714076515)|
|test-conda-python-3.11-pandas-nightly-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088785/job/43714075688)|
|test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088251/job/43714068888)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088144/job/43714067286)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089502/job/43714076737)|
|test-conda-python-3.12-cpython-debug|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088632/job/43714074359)|
|test-conda-python-3.13|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087947/job/43714066964)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089591/job/43714076708)|
|test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087446/job/43714064221)|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088960/job/43714075985)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088860/job/43714074597)|
|test-cuda-python-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088155/job/43714068608)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089010/job/43714075961)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088624/job/43714073024)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087333/job/43714063563)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088084/job/43714068369)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087974/job/43714068347)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087109/job/43714062877)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088494/job/43714073032)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/43714067206)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088633/job/43714073195)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088287/job/43714068907)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087766/job/43714066061)|
|test-r-extra-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088273/job/43714068918)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087306/job/43714063530)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089040/job/43714076010)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087660/job/43714065439)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087973/job/43714068356)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088319/job/43714074278)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087934/job/43714066404)|
|test-r-linux-sanitizers|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088340/job/43714071487)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089113/job/43714074735)|
|test-r-m1-san|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089483/job/43714076529)|
|test-r-macos-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089036/job/43714073463)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/43714067711)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088517/job/43714071885)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/43714068965)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/43714066571)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/43714071102)|
|test-r-rhub-ubuntu-release-latest|[](https://github.com/ursacomputing/crossbow/runs/43714067680)|
|test-r-rocker-r-ver-latest|[](https://github.com/ursacomputing/crossbow/runs/43714071571)|
|test-r-rstudio-r-base-4.1-opensuse155|[](https://github.com/ursacomputing/crossbow/runs/43714070589)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/43714067598)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088935/job/43714074640)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088377/job/43714074325)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088713/job/43714074460)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088380/job/43714071874)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089493/job/43714078160)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088712/job/43714073367)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087944/job/43714066935)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089125/job/43714076217)|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089046/job/43714075986)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/15529087476/job/43714064681)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088641/job/43714073274)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088922/job/43714074583)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/15529089245/job/43714076523)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088106/job/43714068579)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088007/job/43714068353)|
|test-ubuntu-24.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/15529088917/job/43714075726)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46741:
URL: https://github.com/apache/arrow/pull/46741#issuecomment-3043395829
I close this in favor of #46912. #46912 updates bundled Boost and Apache Thrift. I want to update them separately but there are coupled. So I couldn't do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46741:
URL: https://github.com/apache/arrow/pull/46741#issuecomment-2955086007
`std::iterator`: Issue and PR are available:
* https://issues.apache.org/jira/browse/THRIFT-5698
* https://github.com/apache/thrift/pull/2778
But the PR closed because of no response from maintainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed pull request #46741: GH-46740: [C++] Update bundled Thrift to 0.22.0
URL: https://github.com/apache/arrow/pull/46741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46741:
URL: https://github.com/apache/arrow/pull/46741#issuecomment-2987493600
Ah, sorry. https://github.com/apache/arrow/issues/46745 is the blocker of this.
I had a plan to work on #46745 after https://github.com/apache/arrow/pull/45306 is merged but I haven't worked on it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46741:
URL: https://github.com/apache/arrow/pull/46741#issuecomment-2954904355
@github-actions crossbow submit -g cpp -g python -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46740: [C++] Update bundled Thrift to 0.22.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46741:
URL: https://github.com/apache/arrow/pull/46741#issuecomment-2954904534
:warning: GitHub issue #46740 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org