You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2016/11/15 16:39:36 UTC
zeppelin git commit: [ZEPPELIN-1659] DON'T reset filter whenever each
interpreter setting is updated
Repository: zeppelin
Updated Branches:
refs/heads/master 513f8755a -> 621c527f2
[ZEPPELIN-1659] DON'T reset filter whenever each interpreter setting is updated
### What is this PR for?
Filter is cleared whenever each interpreter setting is updated.
it's sometimes annoying if an user want to debug interpreter settings (I attached GIF)
### What type of PR is it?
[Bug Fix]
### Todos
* [ ] - Task
### What is the Jira issue?
[ZEPPELIN-1659](https://issues.apache.org/jira/browse/ZEPPELIN-1659)
### How should this be tested?
1. insert interpreter filter
2. update a interpreter setting
3. check whether the filter is cleared or not
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: 1ambda <1a...@gmail.com>
Closes #1629 from 1ambda/fix/clear-filter-when-setting-updated and squashes the following commits:
72bac06 [1ambda] fix: DON'T reset filter
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/621c527f
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/621c527f
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/621c527f
Branch: refs/heads/master
Commit: 621c527f275aef2b25d3cc56447e0279dad802b4
Parents: 513f875
Author: 1ambda <1a...@gmail.com>
Authored: Mon Nov 14 20:44:51 2016 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Tue Nov 15 08:39:29 2016 -0800
----------------------------------------------------------------------
zeppelin-web/src/app/interpreter/interpreter.controller.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/621c527f/zeppelin-web/src/app/interpreter/interpreter.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/interpreter/interpreter.controller.js b/zeppelin-web/src/app/interpreter/interpreter.controller.js
index e4bebeb..c503030 100644
--- a/zeppelin-web/src/app/interpreter/interpreter.controller.js
+++ b/zeppelin-web/src/app/interpreter/interpreter.controller.js
@@ -24,6 +24,7 @@
$scope.availableInterpreters = {};
$scope.showAddNewSetting = false;
$scope.showRepositoryInfo = false;
+ $scope.searchInterpreter = '';
$scope._ = _;
ngToast.dismiss();
@@ -346,8 +347,8 @@
.success(function(data, status, headers, config) {
$scope.interpreterSettings[index] = data.body;
removeTMPSettings(index);
+ checkDownloadingDependencies();
thisConfirm.close();
- $route.reload();
})
.error(function(data, status, headers, config) {
console.log('Error %o %o', status, data.message);