[GitHub] [incubator-kyuubi] yangrong688 commented on a diff in pull request #2382: [KYUUBI #2020] [Subtask] Hive Backend Engine - new APIs with hive-service-rpc 3.1.2 - TGetQueryId

[GitBox <gi...@apache.org>]

yangrong688 commented on code in PR #2382:
URL: https://github.com/apache/incubator-kyuubi/pull/2382#discussion_r851134737


##########
externals/kyuubi-hive-sql-engine/src/test/scala/org/apache/kyuubi/engine/hive/operation/HiveOperationSuite.scala:
##########
@@ -30,4 +31,14 @@ class HiveOperationSuite extends HiveEngineTests {
   override protected def jdbcUrl: String = {
     "jdbc:hive2://" + HiveSQLEngine.currentEngine.get.frontendServices.head.connectionUrl + "/;"
   }
+
+  test("test get query id") {

Review Comment:
   Is it ok to write test case for getQueryId here?
   I choose to do it because statement should be instanced to KyuubiStatement to cover this function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org