You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2013/12/10 21:50:24 UTC
Review Request 16161: Added stringifier.hpp to stout/Makefile.am.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16161/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Repository: mesos-git
Description
-------
Review request #15285 breaks 'make distcheck' due to missing entry in 3rdparty/libprocess/3rdparty/stout/Makefile.am for the new stringifier header.
This patch adds the missing entry.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am e46e763
Diff: https://reviews.apache.org/r/16161/diff/
Testing
-------
make distcheck.
Thanks,
Niklas Nielsen
Re: Review Request 16161: Added stringifier.hpp to stout/Makefile.am.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16161/
-----------------------------------------------------------
(Updated Dec. 10, 2013, 8:59 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Addressed Ben's comment.
Repository: mesos-git
Description
-------
Review request #15285 breaks 'make distcheck' due to missing entry in 3rdparty/libprocess/3rdparty/stout/Makefile.am for the new stringifier header.
This patch adds the missing entry.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/Makefile.am e46e763
Diff: https://reviews.apache.org/r/16161/diff/
Testing
-------
make distcheck.
Thanks,
Niklas Nielsen
Re: Review Request 16161: Added stringifier.hpp to stout/Makefile.am.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16161/#review30125
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/Makefile.am
<https://reviews.apache.org/r/16161/#comment57690>
Alphabetical please :)
- Ben Mahler
On Dec. 10, 2013, 8:50 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16161/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2013, 8:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review request #15285 breaks 'make distcheck' due to missing entry in 3rdparty/libprocess/3rdparty/stout/Makefile.am for the new stringifier header.
> This patch adds the missing entry.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am e46e763
>
> Diff: https://reviews.apache.org/r/16161/diff/
>
>
> Testing
> -------
>
> make distcheck.
>
>
> Thanks,
>
> Niklas Nielsen
>
>