You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by agneya2001 <gi...@git.apache.org> on 2016/03/18 09:27:52 UTC

[GitHub] cloudstack-docs-admin pull request: OSPF: WIP formatting documenta...

GitHub user agneya2001 opened a pull request:

    https://github.com/apache/cloudstack-docs-admin/pull/36

    OSPF: WIP formatting documentation for ospf

    WIP: documentation for ospf

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agneya2001/cloudstack-docs-admin master-quagga

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack-docs-admin/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit cb02452042ca1ac8d1d1cbbd3e68e9831f4d8536
Author: Abhinandan Prateek <ab...@shapeblue.com>
Date:   2016-03-18T08:26:30Z

    OSPF: WIP formatting documentation for ospf

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: OSPF: WIP formatting documenta...

Posted by agneya2001 <gi...@git.apache.org>.

Github user agneya2001 commented on the pull request:

    https://github.com/apache/cloudstack-docs-admin/pull/36#issuecomment-199133110
  
    @GabrielBrascher all suggestions are good, made them for some i will have to tune the code, will do that too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin issue #36: OSPF: WIP formatting documentation for ospf

Posted by pdion891 <gi...@git.apache.org>.

Github user pdion891 commented on the issue:

    https://github.com/apache/cloudstack-docs-admin/pull/36
  
    @agneya2001 , any update on the merge of your code in the upstream ?
    I'm keeping this PR open until the actual code get merge into master
    
    Regards,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: OSPF: WIP formatting documenta...

Posted by GabrielBrascher <gi...@git.apache.org>.

Github user GabrielBrascher commented on the pull request:

    https://github.com/apache/cloudstack-docs-admin/pull/36#issuecomment-198702503
  
    Hi @agneya2001, could you please consider the following suggestions?
    - Line 1453, change from "debian" to "Debian";
    - at lines 1476 and 1480, change from "Dhcp, Dns" to "DHCP, DNS"; also, modify from "A example" to "An example";
    - there are some lines with "Ospf" or "ospf", I would choose to keep with "OSPF".
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---