You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/10 08:46:47 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #10284: fix(explore): edit datasource does not update control states
ktmud opened a new pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284
### SUMMARY
Follow up for #10283 .
Even after re-enable the "Edit datasource" menu item, the datasource edit modal doesn't actually update current control state---users have to refresh the page to see their datasource updated. This is because the `actions` object passed to `mapStateToProps` is not the actual reducer dispatch function, but the methods to generate dispatch payload.
The functionality was broken because #10224 and #10264 simplified how `mapStateToProps` is called and removed `actions` from `mapStateToProps`'s signature. Since `DatasourceControl` is the only place where `actions` dispatchers are needed for `mapStateToProps`, and all controls actually [already accepts `actions` as props](https://github.com/apache/incubator-superset/blob/700429f431d20b624e886cf554b2b493793448be/superset-frontend/src/explore/components/ControlPanelsContainer.jsx#L95), it makes sense to keep the function simple and refactor `DatasourceControl` instead.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TEST PLAN
1. Edit a datasource. We recommend start from a table chart.
2. After saving the datasource, you should be able to see the changes to datasource columns, metrics, etc in the controls without refreshing the page.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#issuecomment-656811110
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=h1) Report
> Merging [#10284](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4e4ccd48d64adf187dbc682ebf68a3954a37b943&el=desc) will **decrease** coverage by `4.74%`.
> The diff coverage is `44.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10284 +/- ##
==========================================
- Coverage 70.24% 65.49% -4.75%
==========================================
Files 598 598
Lines 32021 32016 -5
Branches 3234 3236 +2
==========================================
- Hits 22493 20969 -1524
- Misses 9423 10866 +1443
- Partials 105 181 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (-0.01%)` | :arrow_down: |
| #python | `69.74% <ø> (+0.02%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `46.85% <ø> (-30.77%)` | :arrow_down: |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | `94.39% <ø> (-1.87%)` | :arrow_down: |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `15.85% <0.00%> (+0.19%)` | :arrow_up: |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `65.78% <50.00%> (-12.34%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [145 more](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=footer). Last update [4e4ccd4...0880ad3](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#discussion_r452996375
##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -148,11 +160,11 @@ class DatasourceControl extends React.PureComponent {
{t('Explore in SQL Lab')}
</MenuItem>
)}
- {!!this.props.onDatasourceSave && (
+ {this.props.isEditable ? (
Review comment:
I like the peace of mind ternary gives me as it's more explicit and wouldn't break things when `isEditable` is a truthy non-boolean value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#discussion_r453003794
##########
File path: superset-frontend/spec/javascripts/explore/controlUtils_spec.jsx
##########
@@ -27,7 +27,6 @@ import {
getFormDataFromControls,
applyMapStateToPropsToControl,
getAllControlsState,
- getControlsState,
Review comment:
This was accidentally added in #10264
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#issuecomment-656744357
Thanks much for stepping in @ktmud , much appreciated!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#discussion_r452974200
##########
File path: superset-frontend/src/explore/controls.jsx
##########
@@ -204,9 +204,9 @@ export const controls = {
label: t('Datasource'),
default: null,
description: null,
- mapStateToProps: (state, control, actions) => ({
- datasource: state.datasource,
- onDatasourceSave: actions ? actions.setDatasource : () => {},
+ mapStateToProps: ({ datasource }) => ({
+ datasource,
+ isEditable: !!datasource,
Review comment:
Could you please set this isEditable a datasource property? in airbnb we do have use-case that don't allow user to edit certain datasources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#discussion_r452995039
##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -148,11 +160,11 @@ class DatasourceControl extends React.PureComponent {
{t('Explore in SQL Lab')}
</MenuItem>
)}
- {!!this.props.onDatasourceSave && (
+ {this.props.isEditable ? (
Review comment:
Maybe. I think either is fine since Prettier doesn't complain.
##########
File path: superset-frontend/src/explore/controls.jsx
##########
@@ -204,9 +204,9 @@ export const controls = {
label: t('Datasource'),
default: null,
description: null,
- mapStateToProps: (state, control, actions) => ({
- datasource: state.datasource,
- onDatasourceSave: actions ? actions.setDatasource : () => {},
+ mapStateToProps: ({ datasource }) => ({
+ datasource,
+ isEditable: !!datasource,
Review comment:
Let's do that in a future refactor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#discussion_r452974200
##########
File path: superset-frontend/src/explore/controls.jsx
##########
@@ -204,9 +204,9 @@ export const controls = {
label: t('Datasource'),
default: null,
description: null,
- mapStateToProps: (state, control, actions) => ({
- datasource: state.datasource,
- onDatasourceSave: actions ? actions.setDatasource : () => {},
+ mapStateToProps: ({ datasource }) => ({
+ datasource,
+ isEditable: !!datasource,
Review comment:
Could you please add `isEditable` as datasource property? in airbnb we do have use-case that don't allow user to edit certain datasources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud merged pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#discussion_r452996375
##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -148,11 +160,11 @@ class DatasourceControl extends React.PureComponent {
{t('Explore in SQL Lab')}
</MenuItem>
)}
- {!!this.props.onDatasourceSave && (
+ {this.props.isEditable ? (
Review comment:
I like the piece of mind ternary gives me as it's more explicit and wouldn't break things when `isEditable` is a truthy non-boolean value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#discussion_r452709750
##########
File path: superset-frontend/src/explore/controls.jsx
##########
@@ -204,9 +204,9 @@ export const controls = {
label: t('Datasource'),
default: null,
description: null,
- mapStateToProps: (state, control, actions) => ({
- datasource: state.datasource,
- onDatasourceSave: actions ? actions.setDatasource : () => {},
+ mapStateToProps: ({ datasource }) => ({
+ datasource,
+ isEditable: !!datasource,
Review comment:
Idea for future plan: this `isEditable` attribute should probably be a datasource attribute, based on user access or datasource metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#discussion_r452996375
##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -148,11 +160,11 @@ class DatasourceControl extends React.PureComponent {
{t('Explore in SQL Lab')}
</MenuItem>
)}
- {!!this.props.onDatasourceSave && (
+ {this.props.isEditable ? (
Review comment:
I like the peace of mind ternary gives me as it's more explicit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#discussion_r452979746
##########
File path: superset-frontend/src/explore/components/controls/DatasourceControl.jsx
##########
@@ -148,11 +160,11 @@ class DatasourceControl extends React.PureComponent {
{t('Explore in SQL Lab')}
</MenuItem>
)}
- {!!this.props.onDatasourceSave && (
+ {this.props.isEditable ? (
Review comment:
is `this.props.isEditable && (<MenuItem>)` prettier?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#issuecomment-656808208
Cypress failing because of the notorious dashboard filter test again. I swear someday I'll find a fix...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud closed pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10284: fix(explore): edit datasource does not update control states
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10284:
URL: https://github.com/apache/incubator-superset/pull/10284#issuecomment-656811110
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=h1) Report
> Merging [#10284](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4e4ccd48d64adf187dbc682ebf68a3954a37b943&el=desc) will **decrease** coverage by `4.76%`.
> The diff coverage is `44.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10284 +/- ##
==========================================
- Coverage 70.24% 65.47% -4.77%
==========================================
Files 598 598
Lines 32021 32016 -5
Branches 3234 3236 +2
==========================================
- Hits 22493 20963 -1530
- Misses 9423 10872 +1449
- Partials 105 181 +76
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <44.44%> (-0.01%)` | :arrow_down: |
| #python | `69.71% <ø> (-0.01%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/components/TooltipWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVG9vbHRpcFdyYXBwZXIuanN4) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `46.85% <ø> (-30.77%)` | :arrow_down: |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | `94.39% <ø> (-1.87%)` | :arrow_down: |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `15.85% <0.00%> (+0.19%)` | :arrow_up: |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | `65.78% <50.00%> (-12.34%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [148 more](https://codecov.io/gh/apache/incubator-superset/pull/10284/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=footer). Last update [4e4ccd4...0880ad3](https://codecov.io/gh/apache/incubator-superset/pull/10284?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org