You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Lukasz Lenart <lu...@apache.org> on 2016/07/28 09:47:02 UTC
Re: URL validation and capitals
2016-05-09 8:38 GMT+02:00 Greg Huber <gr...@gmail.com>:
> A while back I though I read a fix on capitals on the url validator. It
> now seems to be blacking them again.
>
> http://www.appache.org/TEST
>
> I do have some URL's with capitals so it might have worked at some time?
Yeah, looks like the RegEx check is case-sensitive
https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/validator/validators/URLValidator.java#L58
Can you register a ticket?
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: URL validation and capitals
Posted by Lukasz Lenart <lu...@apache.org>.
2016-07-28 12:48 GMT+02:00 Greg Huber <gr...@gmail.com>:
> Ok, forgot about this one, WW-4671
> <https://issues.apache.org/jira/browse/WW-4671>
Me never forget ;-)
> May be it would be easier to lowercase the url to start rather than change
> the rather complex regex ?
It's just a matter of using Pattern.CASE_INSENSITIVE flag ;-)
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: URL validation and capitals
Posted by Greg Huber <gr...@gmail.com>.
Ok, forgot about this one, WW-4671
<https://issues.apache.org/jira/browse/WW-4671>
May be it would be easier to lowercase the url to start rather than change
the rather complex regex ?
Cheers.
On 28 July 2016 at 10:47, Lukasz Lenart <lu...@apache.org> wrote:
> 2016-05-09 8:38 GMT+02:00 Greg Huber <gr...@gmail.com>:
> > A while back I though I read a fix on capitals on the url validator. It
> > now seems to be blacking them again.
> >
> > http://www.appache.org/TEST
> >
> > I do have some URL's with capitals so it might have worked at some time?
>
> Yeah, looks like the RegEx check is case-sensitive
>
> https://github.com/apache/struts/blob/master/core/src/main/java/com/opensymphony/xwork2/validator/validators/URLValidator.java#L58
>
> Can you register a ticket?
>
>
> Regards
> --
> Łukasz
> + 48 606 323 122 http://www.lenart.org.pl/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>