[jira] [Comment Edited] (IGNITE-8310) CPP: Remove strong dependency on Boost 1.58.0

["Nikolay Izhikov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448443#comment-16448443 ] 

Nikolay Izhikov edited comment on IGNITE-8310 at 4/23/18 5:00 PM:
------------------------------------------------------------------

Hello, [~isapego].

I've updated teamcity library sources.
And now with changes from PR [1] I can build and run cpp tests locally on latest Ubuntu Linux with boost 1.62.

I use following scripts to compile an run
build.sh
{{code}}
#!/bin/sh

make clean
libtoolize && aclocal && autoheader && automake --add-missing && autoreconf
./configure --enable-odbc --enable-tests
make
sudo make install
odbcinst -i -d -f ./odbc/install/ignite-odbc-install.ini
{{code}}

run-tests.sh
{{code}}
#!/bin/sh

export BOOST_TEST_CATCH_SYSTEM_ERRORS=no
export IGNITE_NATIVE_TEST_CLASSPATH=true
export IGNITE_NATIVE_TEST_CPP_CONFIG_PATH=/home/dragon/src/ignite/modules/platforms/cpp/core-test/config
export IGNITE_NATIVE_TEST_ODBC_CONFIG_PATH=/home/dragon/src/ignite/modules/platforms/cpp/odbc-test/config
export LD_LIBRARY_PATH=$LD_LIBARY_PATH:$JAVA_HOME/jre/lib/amd64/server

./core-test/ignite-tests

echo Core tests finished! Odbc tests starting:
sleep 5

./odbc-test/ignite-odbc-tests
{{code}}

Can you look at my changes?

I'm not an expert in CPP, but changes in sources are simple replacement and couple of additions.
Can you give me an advice? 
What else should be done to make this changes acceptable to master?

[1] https://github.com/apache/ignite/pull/3903


was (Author: nizhikov):
Hello, [~isapego].

I've updated teamcity library sources.
And now with changes from PR [1] I can build and run cpp tests locally on latest Ubuntu Linux with boost 1.62.

I use following scripts to compile an run
build.sh
{{code:sh}}
#!/bin/sh

make clean
libtoolize && aclocal && autoheader && automake --add-missing && autoreconf
./configure --enable-odbc --enable-tests
make
sudo make install
odbcinst -i -d -f ./odbc/install/ignite-odbc-install.ini
{{code}}

run-tests.sh
{{code:sh}}
#!/bin/sh

export BOOST_TEST_CATCH_SYSTEM_ERRORS=no
export IGNITE_NATIVE_TEST_CLASSPATH=true
export IGNITE_NATIVE_TEST_CPP_CONFIG_PATH=/home/dragon/src/ignite/modules/platforms/cpp/core-test/config
export IGNITE_NATIVE_TEST_ODBC_CONFIG_PATH=/home/dragon/src/ignite/modules/platforms/cpp/odbc-test/config
export LD_LIBRARY_PATH=$LD_LIBARY_PATH:$JAVA_HOME/jre/lib/amd64/server

./core-test/ignite-tests

echo Core tests finished! Odbc tests starting:
sleep 5

./odbc-test/ignite-odbc-tests
{{code}}

Can you look at my changes?

I'm not an expert in CPP, but changes in sources are simple replacement and couple of additions.
Can you give me an advice? 
What else should be done to make this changes acceptable to master?

[1] https://github.com/apache/ignite/pull/3903

> CPP: Remove strong dependency on Boost 1.58.0
> ---------------------------------------------
>
>                 Key: IGNITE-8310
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8310
>             Project: Ignite
>          Issue Type: Improvement
>          Components: odbc, platforms
>    Affects Versions: 2.4
>            Reporter: Igor Sapego
>            Assignee: Nikolay Izhikov
>            Priority: Major
>              Labels: boost, cpp, odbc
>             Fix For: 2.6
>
>
> Currently, tests for C++ client and ODBC depends on the Boost 1.58.0. There is a strong dependency on the exact version, which causes troubles for the developers and which should not be there from the very beginning as we do not really need some features from this particular version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)