[jira] [Comment Edited] (MRUNIT-198) Serialization is missing in MockMultipleOutputs

["Lars Grote (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRUNIT-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894550#comment-13894550 ] 

Lars Grote edited comment on MRUNIT-198 at 2/7/14 2:04 PM:
-----------------------------------------------------------

Sorry! Use this patch: MRUNIT-198-1.patch I build the first one the wrong way around.



was (Author: lgrote):
Sorry! Use this path: MRUNIT-198-1.patch I build the first one the wrong way around.


> Serialization is missing in MockMultipleOutputs
> -----------------------------------------------
>
>                 Key: MRUNIT-198
>                 URL: https://issues.apache.org/jira/browse/MRUNIT-198
>             Project: MRUnit
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Lars Grote
>             Fix For: 1.1.0
>
>         Attachments: MRUNIT-198-1.patch, MRUNIT-198.patch
>
>
> Hi, 
> with issue MRUNIT-13 MockMultipleOutputs was introduced. Which is great! Unfortunately the inner class MockRecordWriter doesn't serialize the Object and therefore isn't storing a copy of the Object but the Object itself. I would suggest to use org.apache.hadoop.mrunit.internal.output.MockOutputCollector instead of the inner class. This Collector does store a copy of the Object and I see no point in having more or less the same Collector/Writer twice. 
> Another thing that bugs me, is that MockMultipleOutputs requires you to use Comparable Objects in your MR Jobs, and I don't see for what reason this restriction is imposed on me.
> I'll provide a patch for this soon and would be glad if someone can comment on it. 
> Cheers, Lars 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)