You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by Nick Lothian <nl...@essential.com.au> on 2003/12/08 23:29:11 UTC
[Patch] Pluto Logging
I noticed this is still on the to-do list.
Do I need to do anything else to get this committed?
-----Original Message-----
From: Nick Lothian
Sent: Wednesday, 3 December 2003 9:33 AM
To: 'pluto-dev@jakarta.apache.org'
Subject: RE: Pluto Logging
A couple of patchfiles (sorry I can't do it in one - not being able to
create patches against CVS is very annoying).
1) LogServiceCommonsLoggingImpl.java.patch
- Apply to
jakarta-pluto\src\portal\org\apache\pluto\portalImpl\services\
- Creates LogServiceCommonsLoggingImpl.java
2) services.properties.patch
- Apply to jakarta-pluto\war\WEB-INF\config
- Sets the default configuration to use commons logging.
You'll also need commons-logging-api.jar to build
(<http://apache.planetmirror.com.au/dist/jakarta/commons/logging/binaries/co
mmons-logging-1.0.3.zip>). This should go in jakarta-pluto\lib\portal. I
don't think this should be included in the pluto war since Tomcat already
includes commons logging, so I haven't modified the build file.
Also, the Maven build (when that is commited) will need updating for this
patch.
Nick
-----Original Message-----
From: Weaver, Scott [mailto:Sweaver@rippe.com]
Sent: Tuesday, 2 December 2003 12:26 AM
To: pluto-dev@jakarta.apache.org
Subject: RE: Pluto Logging
Importance: Low
> Sure, please go ahead and sent your patch. Sometime ago it was proposed
> to move all logging to commons logging (Scott mentioned to work on this
> if I remember correctly). This may also solve your requirements.
I did, just have the free time lately to actually do it. If you do send in
patches I will commit them ASAP.
Regards,
*======================3D==========*
| Scott T Weaver |
| <we...@apache.org> |
| Apache Jetspeed Portal Project |
| Apache Pluto Portlet Container |
*======================3D==========*
> -----Original Message-----
> From: Stefan Hepper [mailto:sthepper@hursley.ibm.com]
> Sent: Tuesday, December 02, 2003 1:15 AM
> To: pluto-dev@jakarta.apache.org
> Subject: Re: Pluto Logging
>
> The reason for this was that it is the simplest way of doing it. As
> said, the portalImpl part is only a basic driver to see pluto running
> and pass the TCK tests.
>
> Sure, please go ahead and sent your patch. Sometime ago it was proposed
> to move all logging to commons logging (Scott mentioned to work on this
> if I remember correctly). This may also solve your requirements.
>
> Stefan
>
> Nick Lothian wrote:
>
> > Is there a reason that the
> > org.apache.pluto.portalImpl.services.log.LogServiceImpl class logs to
> > System.out rather than using something more useful (commons-logging or
> > something?). If not, will you accept patches to modify this?
> >
> > Is the proper way to configure this to set it in the services.properties
> > file in the "config" directory?
> >
Re: [Patch] Pluto Logging
Posted by Michael Blum <bl...@apache.org>.
Nick, I am going to commit your patches on behalf of you. In between I
have managed the integration of the patches in my local environment.
You have not provided with the patches any new property file for the
enabling/configuration of logging. Are no new properties needed for the
configuration of the new logging service implementation?
Michael
Nick Lothian wrote:
>I noticed this is still on the to-do list.
>
>Do I need to do anything else to get this committed?
>
>-----Original Message-----
>From: Nick Lothian
>Sent: Wednesday, 3 December 2003 9:33 AM
>To: 'pluto-dev@jakarta.apache.org'
>Subject: RE: Pluto Logging
>
>
>
>A couple of patchfiles (sorry I can't do it in one - not being able to
>create patches against CVS is very annoying).
>
>1) LogServiceCommonsLoggingImpl.java.patch
> - Apply to
>jakarta-pluto\src\portal\org\apache\pluto\portalImpl\services\
> - Creates LogServiceCommonsLoggingImpl.java
>
>2) services.properties.patch
> - Apply to jakarta-pluto\war\WEB-INF\config
> - Sets the default configuration to use commons logging.
>
>You'll also need commons-logging-api.jar to build
>(<http://apache.planetmirror.com.au/dist/jakarta/commons/logging/binaries/co
>mmons-logging-1.0.3.zip>). This should go in jakarta-pluto\lib\portal. I
>don't think this should be included in the pluto war since Tomcat already
>includes commons logging, so I haven't modified the build file.
>
>Also, the Maven build (when that is commited) will need updating for this
>patch.
>
>Nick
>
>-----Original Message-----
>From: Weaver, Scott [mailto:Sweaver@rippe.com]
>Sent: Tuesday, 2 December 2003 12:26 AM
>To: pluto-dev@jakarta.apache.org
>Subject: RE: Pluto Logging
>Importance: Low
>
>
>
>
>>Sure, please go ahead and sent your patch. Sometime ago it was proposed
>>to move all logging to commons logging (Scott mentioned to work on this
>>if I remember correctly). This may also solve your requirements.
>>
>>
>I did, just have the free time lately to actually do it. If you do send in
>patches I will commit them ASAP.
>Regards,
>*======================3D==========*
>| Scott T Weaver |
>| <we...@apache.org> |
>| Apache Jetspeed Portal Project |
>| Apache Pluto Portlet Container |
>*======================3D==========*
>
>
>>-----Original Message-----
>>From: Stefan Hepper [mailto:sthepper@hursley.ibm.com]
>>Sent: Tuesday, December 02, 2003 1:15 AM
>>To: pluto-dev@jakarta.apache.org
>>Subject: Re: Pluto Logging
>>
>>The reason for this was that it is the simplest way of doing it. As
>>said, the portalImpl part is only a basic driver to see pluto running
>>and pass the TCK tests.
>>
>>Sure, please go ahead and sent your patch. Sometime ago it was proposed
>>to move all logging to commons logging (Scott mentioned to work on this
>>if I remember correctly). This may also solve your requirements.
>>
>>Stefan
>>
>>Nick Lothian wrote:
>>
>>
>>
>>>Is there a reason that the
>>>org.apache.pluto.portalImpl.services.log.LogServiceImpl class logs to
>>>System.out rather than using something more useful (commons-logging or
>>>something?). If not, will you accept patches to modify this?
>>>
>>>Is the proper way to configure this to set it in the services.properties
>>>
>>>
>
>
>
>>>file in the "config" directory?
>>>
>>>
>>>
>
>
>