You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by DaanHoogland <gi...@git.apache.org> on 2015/07/29 10:50:54 UTC
[GitHub] cloudstack pull request: unittesting: test resolution is not guara...
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/633
unittesting: test resolution is not guaranteed to be exact
a lot of validation pull requests are failing over this test. It should pass but it's failure is environmental in any observed case so far.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack test-resolution
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/633.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #633
----
commit 2c110ab70949d49da1552abc299a3413bdc61b37
Author: Daan Hoogland <da...@gmail.com>
Date: 2015-07-29T08:46:30Z
unittesting: test resolution is not guaranteed to be exact
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: unittesting: test resolution is not guara...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/633#issuecomment-135033195
@DaanHoogland: @wilderrodrigues will make a PR to remove it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: unittesting: test resolution is not guara...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/633
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: unittesting: test resolution is not guara...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/633#issuecomment-125896500
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: unittesting: test resolution is not guara...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/633#issuecomment-125896323
Thanks, @DaanHoogland!
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: unittesting: test resolution is not guara...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/633#issuecomment-135028483
@DaanHoogland @wilderrodrigues @bhaisaab
What's the purpose of having this unit test?
I've just seen this unit test fail in a travis build (https://travis-ci.org/miguelaferreira/cloudstack/jobs/77300485). What needs to be done in response to this failure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: unittesting: test resolution is not guara...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/633#issuecomment-135032095
@miguelaferreira it is proven to be of no use. For what I am concerned we should remove it totally. We can not guarantee any kind of realtime result in/with this test.
The period checked for had been lengthened beyond the 2 ms. If we lengthen the test period over 3 milisecs when testing 2 there is no longer any test being done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---