You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/13 14:03:25 UTC
[kudu-CR] [java] Upgrade to Gradle 6.2.2
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15430
Change subject: [java] Upgrade to Gradle 6.2.2
......................................................................
[java] Upgrade to Gradle 6.2.2
This patch makes the major version upgrade to Gradle 6.2.2.
I have been using this version without issue for quite some time
and there are many performance and stability benefits.
Some of the notable features are:
- Stable Gradle build cache (similar to ccache for c++)
- Stable parallel build execution
- Improved dependency caching
- JDK13 Support
- Improved Scala incremental compilation
- Signing Plugin now uses SHA512 instead of SHA1
- Wrapper tries to recover from an invalid Gradle installation
- Tons of fixed issues and performance improvements
See the various release notes here for more:
- https://docs.gradle.org/6.0/release-notes.html
- https://docs.gradle.org/6.1/release-notes.html
- https://docs.gradle.org/6.2/release-notes.html
I enabled parallel builds by default, but would like to experiment
more with build caching before enabling it by default.
In the meantime you can use the build cache by adding
`--build-cache` when calling Gradle.
While upgrading Gradle I also upgraded the plugins to their latest
versions.
Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
---
M java/buildSrc/build.gradle
M java/gradle.properties
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
M java/kudu-backup-tools/build.gradle
M java/kudu-spark/build.gradle
8 files changed, 13 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/15430/1
--
To view, visit http://gerrit.cloudera.org:8080/15430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Upgrade to Gradle 6.2.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15430 )
Change subject: [java] Upgrade to Gradle 6.2.2
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15430/1/java/gradlew
File java/gradlew:
http://gerrit.cloudera.org:8080/#/c/15430/1/java/gradlew@87
PS1, Line 87: /
> nit: an extra symbol
Done
http://gerrit.cloudera.org:8080/#/c/15430/1/java/gradlew@87
PS1, Line 87: v6.0.0
> Shouldn't this be 6.2.2?
Done
--
To view, visit http://gerrit.cloudera.org:8080/15430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Mar 2020 16:29:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Upgrade to Gradle 6.2.2
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15430 )
Change subject: [java] Upgrade to Gradle 6.2.2
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Mar 2020 18:13:39 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Upgrade to Gradle 6.2.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15430 )
Change subject: [java] Upgrade to Gradle 6.2.2
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15430/1/java/gradlew
File java/gradlew:
http://gerrit.cloudera.org:8080/#/c/15430/1/java/gradlew@87
PS1, Line 87: v6.0.0
> Shouldn't this be 6.2.2?
The wrapper jar isn't really version dependent given it rarely/never changes. I bumped it to 6.0.0 given this is a major change, but it wasn't really required. I can bump it to 6.2.2 and add that comment.
--
To view, visit http://gerrit.cloudera.org:8080/15430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Mar 2020 16:28:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Upgrade to Gradle 6.2.2
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15430 )
Change subject: [java] Upgrade to Gradle 6.2.2
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15430/1/java/gradlew
File java/gradlew:
http://gerrit.cloudera.org:8080/#/c/15430/1/java/gradlew@87
PS1, Line 87: v6.0.0
Shouldn't this be 6.2.2?
--
To view, visit http://gerrit.cloudera.org:8080/15430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Mar 2020 15:47:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Upgrade to Gradle 6.2.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15430 )
Change subject: [java] Upgrade to Gradle 6.2.2
......................................................................
[java] Upgrade to Gradle 6.2.2
This patch makes the major version upgrade to Gradle 6.2.2.
I have been using this version without issue for quite some time
and there are many performance and stability benefits.
Some of the notable features are:
- Stable Gradle build cache (similar to ccache for c++)
- Stable parallel build execution
- Improved dependency caching
- JDK13 Support
- Improved Scala incremental compilation
- Signing Plugin now uses SHA512 instead of SHA1
- Wrapper tries to recover from an invalid Gradle installation
- Tons of fixed issues and performance improvements
See the various release notes here for more:
- https://docs.gradle.org/6.0/release-notes.html
- https://docs.gradle.org/6.1/release-notes.html
- https://docs.gradle.org/6.2/release-notes.html
I enabled parallel builds by default, but would like to experiment
more with build caching before enabling it by default.
In the meantime you can use the build cache by adding
`--build-cache` when calling Gradle.
While upgrading Gradle I also upgraded the plugins to their latest
versions.
Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
Reviewed-on: http://gerrit.cloudera.org:8080/15430
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/buildSrc/build.gradle
M java/gradle.properties
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
M java/kudu-backup-tools/build.gradle
M java/kudu-spark/build.gradle
8 files changed, 19 insertions(+), 15 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] Upgrade to Gradle 6.2.2
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15430 )
Change subject: [java] Upgrade to Gradle 6.2.2
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15430/1/java/gradlew
File java/gradlew:
http://gerrit.cloudera.org:8080/#/c/15430/1/java/gradlew@87
PS1, Line 87: /
nit: an extra symbol
--
To view, visit http://gerrit.cloudera.org:8080/15430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 13 Mar 2020 16:28:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Upgrade to Gradle 6.2.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15430
to look at the new patch set (#2).
Change subject: [java] Upgrade to Gradle 6.2.2
......................................................................
[java] Upgrade to Gradle 6.2.2
This patch makes the major version upgrade to Gradle 6.2.2.
I have been using this version without issue for quite some time
and there are many performance and stability benefits.
Some of the notable features are:
- Stable Gradle build cache (similar to ccache for c++)
- Stable parallel build execution
- Improved dependency caching
- JDK13 Support
- Improved Scala incremental compilation
- Signing Plugin now uses SHA512 instead of SHA1
- Wrapper tries to recover from an invalid Gradle installation
- Tons of fixed issues and performance improvements
See the various release notes here for more:
- https://docs.gradle.org/6.0/release-notes.html
- https://docs.gradle.org/6.1/release-notes.html
- https://docs.gradle.org/6.2/release-notes.html
I enabled parallel builds by default, but would like to experiment
more with build caching before enabling it by default.
In the meantime you can use the build cache by adding
`--build-cache` when calling Gradle.
While upgrading Gradle I also upgraded the plugins to their latest
versions.
Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
---
M java/buildSrc/build.gradle
M java/gradle.properties
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
M java/kudu-backup-tools/build.gradle
M java/kudu-spark/build.gradle
8 files changed, 19 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/15430/2
--
To view, visit http://gerrit.cloudera.org:8080/15430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] Upgrade to Gradle 6.2.2
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15430
to look at the new patch set (#3).
Change subject: [java] Upgrade to Gradle 6.2.2
......................................................................
[java] Upgrade to Gradle 6.2.2
This patch makes the major version upgrade to Gradle 6.2.2.
I have been using this version without issue for quite some time
and there are many performance and stability benefits.
Some of the notable features are:
- Stable Gradle build cache (similar to ccache for c++)
- Stable parallel build execution
- Improved dependency caching
- JDK13 Support
- Improved Scala incremental compilation
- Signing Plugin now uses SHA512 instead of SHA1
- Wrapper tries to recover from an invalid Gradle installation
- Tons of fixed issues and performance improvements
See the various release notes here for more:
- https://docs.gradle.org/6.0/release-notes.html
- https://docs.gradle.org/6.1/release-notes.html
- https://docs.gradle.org/6.2/release-notes.html
I enabled parallel builds by default, but would like to experiment
more with build caching before enabling it by default.
In the meantime you can use the build cache by adding
`--build-cache` when calling Gradle.
While upgrading Gradle I also upgraded the plugins to their latest
versions.
Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
---
M java/buildSrc/build.gradle
M java/gradle.properties
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
M java/kudu-backup-tools/build.gradle
M java/kudu-spark/build.gradle
8 files changed, 19 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/15430/3
--
To view, visit http://gerrit.cloudera.org:8080/15430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I93b6893500a0502c05d97468c267fb36c61b4918
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)