You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/02/28 04:38:56 UTC

[GitHub] amercode opened a new pull request #314: CB-13865: (IOS-Ipad) Making CameraPopover for imagePicker bigger on Ipad

amercode opened a new pull request #314: CB-13865: (IOS-Ipad) Making CameraPopover for imagePicker bigger on Ipad
URL: https://github.com/apache/cordova-plugin-camera/pull/314
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   IOS - Ipad only
   
   ### What does this PR do?
   Allow the user to set the popover Width and Height on Ipads
   
   ### What testing has been done on this change?
   Modified the automated test cases to accommodate for the change.
   Tested the plugin on the Ipad with different popover height and width as well as not specifying any.
   
   ### Checklist
   - [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ x] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org