You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/22 23:21:56 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24682:
[SPARK-27762][SQL] [FOLLOWUP] Add behavior change for Avro writer in
migration guide
dongjoon-hyun commented on a change in pull request #24682: [SPARK-27762][SQL] [FOLLOWUP] Add behavior change for Avro writer in migration guide
URL: https://github.com/apache/spark/pull/24682#discussion_r286725040
##########
File path: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala
##########
@@ -234,7 +234,7 @@ class AvroSerializer(rootCatalystType: DataType, rootAvroType: Schema, nullable:
}
private def resolveNullableType(avroType: Schema, nullable: Boolean): Schema = {
- if (nullable && avroType.getType != NULL) {
+ if (avroType.getType == Type.UNION && nullable) {
Review comment:
Yep. This is for a better error!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org