You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <da...@brondsema.net> on 2016/10/04 18:31:09 UTC
[allura:tickets] #8132 Fix comment threading when email In-Reply-To header
isn't useful
---
** [tickets:#8132] Fix comment threading when email In-Reply-To header isn't useful**
**Status:** in-progress
**Milestone:** unreleased
**Created:** Tue Oct 04, 2016 06:31 PM UTC by Dave Brondsema
**Last Updated:** Tue Oct 04, 2016 06:31 PM UTC
**Owner:** Dave Brondsema
Normally when replying to a thread, the `In-Reply-To` header is set to something like `</p...@allura.p.forge-allura.apache.org>` and then that is used to insert the message in the right part of the thread. However, sometimes that header has just a "regular" message id like `CAFTnE1nM2MfG3o2WTq_bDWuRjmspnEiCw-d_UiWbSaT3aLyKLg@mail.gmail.com` and then it creates a whole new thread. One case when this can happen is if you reply to your own message, then your mail client will use your sent mail's ID instead of the notification mail ID.
We should be able to use the `References` header sitll though. E.g. `References: <55...@allura.p.forge-allura.apache.org> </p...@allura.p.forge-allura.apache.org> </p...@allura.p.forge-allura.apache.org>`
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8132 Fix comment threading when email In-Reply-To header
isn't useful
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: review --> closed
---
** [tickets:#8132] Fix comment threading when email In-Reply-To header isn't useful**
**Status:** closed
**Milestone:** unreleased
**Created:** Tue Oct 04, 2016 06:31 PM UTC by Dave Brondsema
**Last Updated:** Thu Oct 13, 2016 04:53 PM UTC
**Owner:** Dave Brondsema
Normally when replying to a thread, the `In-Reply-To` header is set to something like `</p...@allura.p.forge-allura.apache.org>` and then that is used to insert the message in the right part of the thread. However, sometimes that header has just a "regular" message id like `CAFTnE1nM2MfG3o2WTq_bDWuRjmspnEiCw-d_UiWbSaT3aLyKLg@mail.gmail.com` and then it creates a whole new thread. One case when this can happen is if you reply to your own message, then your mail client will use your sent mail's ID instead of the notification mail ID.
We should be able to use the `References` header sitll though. E.g. `References: <55...@allura.p.forge-allura.apache.org> </p...@allura.p.forge-allura.apache.org> </p...@allura.p.forge-allura.apache.org>`
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8132 Fix comment threading when email In-Reply-To header
isn't useful
Posted by Dave Brondsema <da...@brondsema.net>.
Fix on branch db/8132
To test, you can generate some emails via the web interface. Then use `telnet` to send an email into allura's smtp listener, see https://forge-allura.apache.org/p/allura/wiki/Notes/ for details. For the email, have a missing or bogus `In-Reply-To:` header, and include a `References:` header with valid values (taken from the `References` and `Message-ID` values in a notification email)
---
** [tickets:#8132] Fix comment threading when email In-Reply-To header isn't useful**
**Status:** in-progress
**Milestone:** unreleased
**Created:** Tue Oct 04, 2016 06:31 PM UTC by Dave Brondsema
**Last Updated:** Tue Oct 04, 2016 06:31 PM UTC
**Owner:** Dave Brondsema
Normally when replying to a thread, the `In-Reply-To` header is set to something like `</p...@allura.p.forge-allura.apache.org>` and then that is used to insert the message in the right part of the thread. However, sometimes that header has just a "regular" message id like `CAFTnE1nM2MfG3o2WTq_bDWuRjmspnEiCw-d_UiWbSaT3aLyKLg@mail.gmail.com` and then it creates a whole new thread. One case when this can happen is if you reply to your own message, then your mail client will use your sent mail's ID instead of the notification mail ID.
We should be able to use the `References` header sitll though. E.g. `References: <55...@allura.p.forge-allura.apache.org> </p...@allura.p.forge-allura.apache.org> </p...@allura.p.forge-allura.apache.org>`
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8132 Fix comment threading when email In-Reply-To header
isn't useful
Posted by Dave Brondsema <da...@brondsema.net>.
- **status**: in-progress --> review
---
** [tickets:#8132] Fix comment threading when email In-Reply-To header isn't useful**
**Status:** review
**Milestone:** unreleased
**Created:** Tue Oct 04, 2016 06:31 PM UTC by Dave Brondsema
**Last Updated:** Wed Oct 05, 2016 09:58 PM UTC
**Owner:** Dave Brondsema
Normally when replying to a thread, the `In-Reply-To` header is set to something like `</p...@allura.p.forge-allura.apache.org>` and then that is used to insert the message in the right part of the thread. However, sometimes that header has just a "regular" message id like `CAFTnE1nM2MfG3o2WTq_bDWuRjmspnEiCw-d_UiWbSaT3aLyKLg@mail.gmail.com` and then it creates a whole new thread. One case when this can happen is if you reply to your own message, then your mail client will use your sent mail's ID instead of the notification mail ID.
We should be able to use the `References` header sitll though. E.g. `References: <55...@allura.p.forge-allura.apache.org> </p...@allura.p.forge-allura.apache.org> </p...@allura.p.forge-allura.apache.org>`
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
[allura:tickets] #8132 Fix comment threading when email In-Reply-To header
isn't useful
Posted by Kenton Taylor <kt...@slashdotmedia.com>.
Fix for this looks good, clear to merge IMO.
---
** [tickets:#8132] Fix comment threading when email In-Reply-To header isn't useful**
**Status:** review
**Milestone:** unreleased
**Created:** Tue Oct 04, 2016 06:31 PM UTC by Dave Brondsema
**Last Updated:** Wed Oct 05, 2016 09:58 PM UTC
**Owner:** Dave Brondsema
Normally when replying to a thread, the `In-Reply-To` header is set to something like `</p...@allura.p.forge-allura.apache.org>` and then that is used to insert the message in the right part of the thread. However, sometimes that header has just a "regular" message id like `CAFTnE1nM2MfG3o2WTq_bDWuRjmspnEiCw-d_UiWbSaT3aLyKLg@mail.gmail.com` and then it creates a whole new thread. One case when this can happen is if you reply to your own message, then your mail client will use your sent mail's ID instead of the notification mail ID.
We should be able to use the `References` header sitll though. E.g. `References: <55...@allura.p.forge-allura.apache.org> </p...@allura.p.forge-allura.apache.org> </p...@allura.p.forge-allura.apache.org>`
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.