You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by bitblender <gi...@git.apache.org> on 2016/12/10 20:10:27 UTC
[GitHub] drill pull request #690: DRILL-5121 A memory leak is observed when exact cas...
GitHub user bitblender opened a pull request:
https://github.com/apache/drill/pull/690
DRILL-5121 A memory leak is observed when exact case is not specified for a column in a filter condition
Fix for https://issues.apache.org/jira/browse/DRILL-5121.
Changes fieldVectorMap in ScanBatch to a CaseInsensitiveMap to workaround the memory leak described in the bug.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bitblender/drill DRILL-5121
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #690
----
commit 8178e2ac620cdde534b8235e1b699b92bbad87c8
Author: karthik <km...@maprtech.com>
Date: 2016-11-14T18:36:53Z
DRILL-5121 Fix for memory leak. Changes fieldVectorMap in ScanBatch to a CaseInsensitiveMap
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #690: DRILL-5121 A memory leak is observed when exact case is no...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on the issue:
https://github.com/apache/drill/pull/690
The proposed change looks fine for case insensitive store. On the other hand, have you given some thoughts of @Ben-Zvi 's comment about case sensitive store? Will it work for case sensitive store?
You may add one simple testcase to verify that the fix works as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #690: DRILL-5121 A memory leak is observed when exact cas...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/690
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---