[GitHub] [maven] mthmulders commented on a change in pull request #287: [MNG-6065] - Log fail-level option.

[GitBox <gi...@apache.org>]

mthmulders commented on a change in pull request #287: [MNG-6065] - Log fail-level option.
URL: https://github.com/apache/maven/pull/287#discussion_r352483908
 
 

 ##########
 File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
 ##########
 @@ -541,6 +543,18 @@ else if ( cliRequest.commandLine.hasOption( CLIManager.BATCH_MODE )
 
         plexusLoggerManager = new Slf4jLoggerManager();
         slf4jLogger = slf4jLoggerFactory.getLogger( this.getClass().getName() );
+
+        if ( cliRequest.commandLine.hasOption( CLIManager.FAIL_LEVEL ) )
+        {
+            String logLevelThreshold = cliRequest.commandLine.getOptionValue( CLIManager.FAIL_LEVEL );
+
+            if ( slf4jLoggerFactory instanceof MavenSlf4jWrapperFactory )
 
 Review comment:
   I'm missing an `else` here. Is there a situation where this condition is _not_ going to be `true`? If there is, the `fl` switch doesn't work? If so, maybe we should at least say that it's not going to work.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services