You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/08/15 14:16:27 UTC
[GitHub] [drill] arina-ielchiieva commented on a change in pull request
#1843: DRILL-7350: Move RowSet related classes from test folder
arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move RowSet related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314323421
##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/DirectRowSet.java
##########
@@ -132,7 +131,7 @@ public RowSetReader reader() {
@Override
public SingleRowSet toIndirect() {
- return new IndirectRowSet(this, Sets.<Integer>newHashSet());
+ return new IndirectRowSet(this, new HashSet<>());
Review comment:
Should be immutable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services