You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/26 00:43:27 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #30508: Revert "[SPARK-33212][BUILD] Move to shaded clients for Hadoop 3.x profile"

HyukjinKwon commented on a change in pull request #30508:
URL: https://github.com/apache/spark/pull/30508#discussion_r530710551



##########
File path: pom.xml
##########
@@ -1405,24 +1371,8 @@
             <groupId>com.sun.jersey.contribs</groupId>
             <artifactId>*</artifactId>
           </exclusion>
-          <exclusion>
-            <groupId>org.apache.hadoop</groupId>
-            <artifactId>hadoop-yarn-server-resourcemanager</artifactId>
-          </exclusion>
         </exclusions>
       </dependency>
-      <!--

Review comment:
       Ahh .. this is going to be complicated I guess. In the fork in the company I work for, we still keep this change (SPARK-33104) alone. We did not port back SPARK-33212 yet. This is from SBT upgrade actually. 
   
   It broke the test with Hadoop 2 so we still needed this change (SPARK-33104). Let's revert it together first as you proposed for now. I will take a look again to fix it in.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org