You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/07/27 14:21:44 UTC

[GitHub] utzig commented on a change in pull request #197: syscfg: error detection after API resolution

utzig commented on a change in pull request #197: syscfg: error detection after API resolution
URL: https://github.com/apache/mynewt-newt/pull/197#discussion_r205790332
 
 

 ##########
 File path: newt/syscfg/syscfg.go
 ##########
 @@ -1009,6 +1009,15 @@ func (cfg *Cfg) detectAmbiguities() {
 	}
 }
 
+// Detects and records errors in the build's syscfg.  This should only be
+// called after APIs are resolved to avoid false positives.
+func (cfg *Cfg) DetectErrors(flashMap flash.FlashMap) {
 
 Review comment:
   Wouldn't it be better to receive `flashMap` as pointer?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services