[GitHub] [rocketmq] StyleTang commented on a change in pull request #3137: [ISSUE #3136] TraceDataEncoder add SubAfter trace bean timestamp

[GitBox <gi...@apache.org>]

StyleTang commented on a change in pull request #3137:
URL: https://github.com/apache/rocketmq/pull/3137#discussion_r671595465



##########
File path: client/src/main/java/org/apache/rocketmq/client/trace/TraceDataEncoder.java
##########
@@ -104,9 +104,8 @@
                     subAfterContext.setContextCode(Integer.parseInt(line[6]));
                 }
                 // compatible with the old version
-                if (line.length >= 9) {
+                if (line.length >= 8) {
                     subAfterContext.setTimeStamp(Long.parseLong(line[7]));
-                    subAfterContext.setGroupName(line[8]);

Review comment:
       Get it. 
   I removed it because I thought this value is useless, maybe add the branch line.length >= 9 back is a better way. 
   ```
           // compatible with the old version
           if (line.length >= 8) {
               subAfterContext.setTimeStamp(Long.parseLong(line[7]));
           }
           if (line.length >= 9) {
               subAfterContext.setGroupName(Long.parseLong(line[8]));
           }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org