You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/07 07:23:19 UTC
[GitHub] [bookkeeper] StevenLuMT opened a new pull request, #3393: Bugfix for zooKeeper client
StevenLuMT opened a new pull request, #3393:
URL: https://github.com/apache/bookkeeper/pull/3393
Descriptions of the changes in this PR:
### Motivation
zkRetryBackoffMaxRetries is set MAX,
when the ZooKeeperClient is already closed,
the syncCall can't perception this close action,when the old task is fail, new tasks cannot be executed,
then the ZooWorker.syncCallWithRetries can's exited
The screenshots of these codes are to illustrate that when ZooKeeperClient is closed, new tasks cannot be executed
<img width="956" alt="image" src="https://user-images.githubusercontent.com/42990025/177714250-17ed3e4b-1417-45b0-b09a-d28d837bbcf8.png">
<img width="687" alt="image" src="https://user-images.githubusercontent.com/42990025/177714499-2e48cf82-1070-4003-b6db-e6eba92253d5.png">
### Changes
1. add the judgment of whether to close in ZooWorker.syncCallWithRetries
2. update testcase's zkRetryBackoffMaxRetries to default value(Integer.MAX_VALUE)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on code in PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#discussion_r917359753
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ZooKeeperClient.java:
##########
@@ -351,6 +352,7 @@ public void process(WatchedEvent event) {
private void onExpired() {
if (closed.get()) {
// we don't schedule any tries if the client is closed.
+ logger.info("we don't schedule any tries if the client is closed");
Review Comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1177888586
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1177793188
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1193245449
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1193286813
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
eolivelli commented on code in PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#discussion_r916925385
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ZooKeeperClient.java:
##########
@@ -317,6 +317,7 @@ protected ZooKeeperClient(String connectString,
@Override
public void close() throws InterruptedException {
+ logger.info("zooKeeper client start to close...");
Review Comment:
no need to log this at "info" level
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ZooKeeperClient.java:
##########
@@ -351,6 +352,7 @@ public void process(WatchedEvent event) {
private void onExpired() {
if (closed.get()) {
// we don't schedule any tries if the client is closed.
+ logger.info("we don't schedule any tries if the client is closed");
Review Comment:
no need to log this at "info" level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT closed pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT closed pull request #3393: Bugfix for zooKeeper client
URL: https://github.com/apache/bookkeeper/pull/3393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1177449164
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1177305690
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1177931394
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1178439122
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1193442853
@StevenLuMT The flaky test has been resolved by https://github.com/apache/bookkeeper/pull/3415, do we still need this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1193344216
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1179745761
> good catch
>
> can you please add a test case ?
thanks, I will add a testcase @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] HQebupt commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1179077406
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1178609933
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1193339802
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1183313262
There is still exist a zk session timeout failed test, please help take a look, thanks. @StevenLuMT
https://github.com/apache/bookkeeper/runs/7274932865?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1190492031
> There is still exist a zk session timeout failed test, please help take a look, thanks. @StevenLuMT https://github.com/apache/bookkeeper/runs/7274932865?check_suite_focus=true
@hangc0276
thanks for reviewing,
I am coding for it and some bugfixes will be submitted this week to fix the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1193470554
> @StevenLuMT The flaky test has been resolved by #3415, do we still need this fix?
Hello, I will close it for now, and then continue later @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1177856090
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#issuecomment-1177395213
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a diff in pull request #3393: Bugfix for zooKeeper client
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on code in PR #3393:
URL: https://github.com/apache/bookkeeper/pull/3393#discussion_r917359709
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/zookeeper/ZooKeeperClient.java:
##########
@@ -317,6 +317,7 @@ protected ZooKeeperClient(String connectString,
@Override
public void close() throws InterruptedException {
+ logger.info("zooKeeper client start to close...");
Review Comment:
thanks, update log level from info to debug @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org