You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/20 12:28:50 UTC

[GitHub] [incubator-nuttx] cwespressif opened a new pull request #2351: xtensa/esp32: Fix issues of force-sleep

cwespressif opened a new pull request #2351:
URL: https://github.com/apache/incubator-nuttx/pull/2351


   ## Summary
   
   Fix issues of  force-sleep.
   
   ## Impact
   
   1. improve the stability of "force-sleep" function.
   2. fixed the issues of using "force-sleep" when enable "PSRAM".
   3. remove redundant configuration cpu frequency operation.
   
   ## Testing
   
   Using "incubator-nuttx/boards/xtensa/esp32/esp32-core/configs/pm" defconfig to test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] saramonteiro commented on pull request #2351: xtensa/esp32: Fix issues of force-sleep

Posted by GitBox <gi...@apache.org>.
saramonteiro commented on pull request #2351:
URL: https://github.com/apache/incubator-nuttx/pull/2351#issuecomment-732944697


   @cwespressif I missed the changes in arch/xtensa/src/esp32/esp32_pminitialize.c .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #2351: xtensa/esp32: Fix issues of force-sleep

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2351:
URL: https://github.com/apache/incubator-nuttx/pull/2351


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] saramonteiro removed a comment on pull request #2351: xtensa/esp32: Fix issues of force-sleep

Posted by GitBox <gi...@apache.org>.
saramonteiro removed a comment on pull request #2351:
URL: https://github.com/apache/incubator-nuttx/pull/2351#issuecomment-732944697


   @cwespressif I missed the changes in arch/xtensa/src/esp32/esp32_pminitialize.c .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] cwespressif commented on a change in pull request #2351: xtensa/esp32: Fix issues of force-sleep

Posted by GitBox <gi...@apache.org>.
cwespressif commented on a change in pull request #2351:
URL: https://github.com/apache/incubator-nuttx/pull/2351#discussion_r528458218



##########
File path: arch/xtensa/src/esp32/esp32_pm.c
##########
@@ -577,11 +577,11 @@ static int IRAM_ATTR esp32_sleep_start(uint32_t pd_flags)
       esp32_timer_wakeup_prepare();
     }
 
-  esp32_rtc_sleep_start(s_config.wakeup_triggers, 0);
+  result = esp32_rtc_sleep_start(s_config.wakeup_triggers, 0);
 
   /* Restore CPU frequency */
 
-  result = esp32_configure_cpu_freq(cur_freq);
+  esp32_configure_cpu_freq(cur_freq);

Review comment:
       Hi @acassis thanks for your reviewing, I have added “warning” to indicate that there is a problem with the configured cpu frequency.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2351: xtensa/esp32: Fix issues of force-sleep

Posted by GitBox <gi...@apache.org>.
acassis commented on a change in pull request #2351:
URL: https://github.com/apache/incubator-nuttx/pull/2351#discussion_r527700301



##########
File path: arch/xtensa/src/esp32/esp32_pm.c
##########
@@ -577,11 +577,11 @@ static int IRAM_ATTR esp32_sleep_start(uint32_t pd_flags)
       esp32_timer_wakeup_prepare();
     }
 
-  esp32_rtc_sleep_start(s_config.wakeup_triggers, 0);
+  result = esp32_rtc_sleep_start(s_config.wakeup_triggers, 0);
 
   /* Restore CPU frequency */
 
-  result = esp32_configure_cpu_freq(cur_freq);
+  esp32_configure_cpu_freq(cur_freq);

Review comment:
       Because setting a new incorrect frequency value will "fail" it is important to check its return and show a warning to the user.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org