[GitHub] [pulsar] nicoloboschi commented on pull request #15627: [fix][managed-ledger] fix calculation in getNumberOfEntriesInStorage

[GitBox <gi...@apache.org>]

nicoloboschi commented on PR #15627:
URL: https://github.com/apache/pulsar/pull/15627#issuecomment-1149962309

   The new test is failing in the release branches because, in order to pass, it needs also https://github.com/apache/pulsar/pull/14672
   
   ```
   Caused by: java.lang.AssertionError: expected [2] but found [3]
   	at org.testng.Assert.fail(Assert.java:99)
   	at org.testng.Assert.failNotEquals(Assert.java:1037)
   	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
   	at org.testng.Assert.assertEquals(Assert.java:122)
   	at org.testng.Assert.assertEquals(Assert.java:907)
   	at org.testng.Assert.assertEquals(Assert.java:917)
   	at org.apache.bookkeeper.mledger.impl.ManagedLedgerTest.lambda$testGetNumberOfEntriesInStorage$34(ManagedLedgerTest.java:2296)
   	at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
   	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:222)
   	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:209)
   	... 4 more
   ```
   
   I believe that we should NOT port https://github.com/apache/pulsar/pull/14672 to release branches since it's a behaviour change (even if internal). We can just modify the failing test
   
   @HQebupt could you do it?  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org