You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2019/08/01 22:36:00 UTC
[jira] [Resolved] (LUCENE-8906) Lucene50PostingsReader.postings()
casts BlockTermState param to private IntBlockTermState
[ https://issues.apache.org/jira/browse/LUCENE-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Smiley resolved LUCENE-8906.
----------------------------------
Resolution: Fixed
Assignee: David Smiley
Fix Version/s: 8.3
Merged PR. Thanks Bruno!
> Lucene50PostingsReader.postings() casts BlockTermState param to private IntBlockTermState
> -----------------------------------------------------------------------------------------
>
> Key: LUCENE-8906
> URL: https://issues.apache.org/jira/browse/LUCENE-8906
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Reporter: Bruno Roustant
> Assignee: David Smiley
> Priority: Major
> Fix For: 8.3
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Lucene50PostingsReader is the public API that offers the postings() method to read the postings. Any PostingFormat can use it (as well as Lucene50PostingsWriter) to read/write postings.
> But the postings() method asks for a (public) BlockTermState param which is internally cast to the private IntBlockTermState. This BlockTermState is provided by Lucene50PostingsReader.newTermState().
> public PostingsEnum postings(FieldInfo fieldInfo, BlockTermState termState, PostingsEnum reuse, int flags)
> This actually makes impossible to a custom PostingFormat customizing the Block file structure to use this postings() method by providing their (Int)BlockTermState, because they cannot access the FP fields of the IntBlockTermState returned by PostingsReaderBase.newTermState().
> Proposed change:
> * Either make IntBlockTermState public, as well as its fields.
> * Or replace it by an interface in the postings() method. In this case the IntBlockTermState fields currently accessed directly would be replaced by getter/setter.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org