[GitHub] [spark] LuciferYang commented on a diff in pull request #41123: [SPARK-43428][FOLLOW-UP] Utils and JSON Utils refactoring

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #41123:
URL: https://github.com/apache/spark/pull/41123#discussion_r1190161190


##########
common/utils/src/main/scala/org/apache/spark/util/JsonUtils.scala:
##########
@@ -25,9 +25,9 @@ import com.fasterxml.jackson.databind.{DeserializationFeature, ObjectMapper}
 import com.fasterxml.jackson.module.scala.DefaultScalaModule
 
 
-private[spark] object JsonUtils {
+private[spark] trait JsonUtils {
 
-  private val mapper = new ObjectMapper().registerModule(DefaultScalaModule)
+  protected val mapper = new ObjectMapper().registerModule(DefaultScalaModule)

Review Comment:
   We should add type annotation to `protected` member



##########
common/utils/src/main/scala/org/apache/spark/util/JsonUtils.scala:
##########
@@ -39,3 +39,5 @@ private[spark] object JsonUtils {
     new String(baos.toByteArray, StandardCharsets.UTF_8)
   }
 }
+

Review Comment:
   hmm... should we always close `generator` and `baos` in `finally` block(line 37&38)? If so, we can refactor it in this pr
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org