[jira] [Commented] (LUCENE-5797) improve speed of norms merging

["Adrien Grand (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048819#comment-14048819 ] 

Adrien Grand commented on LUCENE-5797:
--------------------------------------

The patch looks good to me. I think the complexity is ok, I was just a bit confused why the size was stored as a long when looking at NormsMap out of context, maybe we could just have a comment about this limitation?

> improve speed of norms merging
> ------------------------------
>
>                 Key: LUCENE-5797
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5797
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>         Attachments: LUCENE-5797.patch
>
>
> Today we use the following procedure:
> * track HashSet<Long> uniqueValues, until it exceeds 256 unique values.
> * convert to array, sort and assign ordinals to each one
> * create encoder map (HashMap<Long,Integer>) to encode each value.
> This results in each value being hashed twice... but the vast majority of the time people will just be using single-byte norms and a simple array is enough for that range.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org