[jira] [Comment Edited] (IGNITE-4799) Remove TcpDiscoverySpi.heartbeatsFrequency parameter

["Yakov Zhdanov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-4799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962738#comment-15962738 ] 

Yakov Zhdanov edited comment on IGNITE-4799 at 4/10/17 11:54 AM:
-----------------------------------------------------------------

Although I have finished the initial removal of the property and fixed tests logic and xml configs to use igniteCfg.metricsUpdateFreq, there is still a lot to do:
# we need to fix documentation to reflect the changes ([~dmagda], can you please take a look and propose changes?)
# need to decide what to do with "maxMissedHeartbeats" property and respective property for client
# should we rename and refactor TCP disco messages and logic to remove all "heartbeat mentions"? Should we go ahead and refactor this as well e.g. to maxMissedMetricUpdates?

Also there are some changes to platforms and webconsole required. [~kuaw26] and [~ptupitsyn] can you take a look at respective parts?

The changes are in origin/ignite-4799


was (Author: yzhdanov):
Although I have finished the initial removal of the property and fixed tests logic and xml configs to use igniteCfg.metricsUpdateFreq, there is still a lot to do:
# we need to fix documentation to reflect the changes ([~dmagda], can you please take a look and propose changes?)
# need to decide what to do with "maxMissedHeartbeats" property and respective property for client
# should we rename and refactor TCP disco messages and logic to remove all "heartbeat mentions"?

The changes are in origin/ignite-4799

> Remove TcpDiscoverySpi.heartbeatsFrequency parameter
> ----------------------------------------------------
>
>                 Key: IGNITE-4799
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4799
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Denis Magda
>            Assignee: Yakov Zhdanov
>              Labels: important
>             Fix For: 2.0
>
>
> {{TcpDiscoverySpi.heartbeatsFrequency}} is no longer used to adjust the heartbeats frequence. It affects the frequency of metrics messages sent over the cluster ring.
> The following has to be done as a part of 2.0 release:
> * Remove {{TcpDiscoverySpi.heartbeatsFrequency}} parameter.
> * Use {{IgniteConfiguraion.getMetricsUpdateFrequency}} to adjust the rate of metrics messages.
> * Make sure {{IgniteConfiguraion.getMetricsUpdateFrequency}} and metrics messages are not participated in the failure detection process. We have to clean up legacy code in {{ServerImpl}}.
> Refer to this discussion for more details:
> http://apache-ignite-developers.2346864.n4.nabble.com/Renaming-TcpDiscoverySpi-heartbeatsFrequency-to-TcpDiscoverySpi-metricsUpdateFrequency-td14941.html 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)