You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "dannycranmer (via GitHub)" <gi...@apache.org> on 2023/10/16 09:17:54 UTC
[PR] [FLINK-33279][Connector/Kinesis] Do not run AWS e2e tests on PR [flink-connector-aws]
dannycranmer opened a new pull request, #106:
URL: https://github.com/apache/flink-connector-aws/pull/106
## Purpose of the change
Prevent AWS E2E tests running on PR
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Significant changes
*(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)*
- [ ] Dependencies have been added or upgraded
- [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`)
- [ ] Serializers have been changed
- [ ] New feature has been introduced
- If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33279][Connector/Kinesis] Do not run AWS e2e tests on PR [flink-connector-aws]
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on code in PR #106:
URL: https://github.com/apache/flink-connector-aws/pull/106#discussion_r1360380742
##########
.github/workflows/common.yml:
##########
@@ -116,7 +116,7 @@ jobs:
mvn clean
- name: Run AWS e2e tests
- if: ${{ env.HAS_AWS_CREDS }}
+ if: env.HAS_AWS_CREDS
Review Comment:
https://github.com/orgs/community/discussions/26516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33279][Connector/Kinesis] Do not run AWS e2e tests on PR [flink-connector-aws]
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer commented on PR #106:
URL: https://github.com/apache/flink-connector-aws/pull/106#issuecomment-1764067812
Note that the AWS E2E tests will run on this PR since it is not using the updated actions config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33279][Connector/Kinesis] Do not run AWS e2e tests on PR [flink-connector-aws]
Posted by "dannycranmer (via GitHub)" <gi...@apache.org>.
dannycranmer merged PR #106:
URL: https://github.com/apache/flink-connector-aws/pull/106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org