[impala] 04/05: IMPALA-8642: krpc should depend on thrift-deps in CMake

[jo...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 270deda049f4f8551742475017e860f1dab3754b
Author: stiga-huang <hu...@gmail.com>
AuthorDate: Sun Jun 9 18:03:24 2019 -0700

    IMPALA-8642: krpc should depend on thrift-deps in CMake
    
    When build with IMPALA_BUILD_THREADS=1, the compiling of krpc will fail
    since kudu_version.cc includes "gen-cpp/Status_types.h" which will be
    built later. We should add dependency on thrift-deps for krpc to avoid
    such a race condition in compiling.
    
    Change-Id: Ieaf9d992340f07fdf88b35fb967553fa2e35b628
    Reviewed-on: http://gerrit.cloudera.org:8080/13569
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 be/src/kudu/rpc/CMakeLists.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/be/src/kudu/rpc/CMakeLists.txt b/be/src/kudu/rpc/CMakeLists.txt
index 91dd484..3b31ec5 100644
--- a/be/src/kudu/rpc/CMakeLists.txt
+++ b/be/src/kudu/rpc/CMakeLists.txt
@@ -96,6 +96,8 @@ add_executable(protoc-gen-krpc protoc-gen-krpc.cc
   # TODO: Consider either removing code that depends on these flags, or namespacing them
   # somehow.
   ${CMAKE_CURRENT_SOURCE_DIR}/../../common/global-flags.cc)
+# IMPALA-8642: kudu_version.cc depends on gen-cpp/Status_types.h in target thrift-deps
+add_dependencies(protoc-gen-krpc thrift-deps)
 target_link_libraries(protoc-gen-krpc
     ${KUDU_BASE_LIBS}
     rpc_header_proto