You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/02 22:01:42 UTC

[GitHub] [airflow] dstandish edited a comment on pull request #13423: Add bash hook

dstandish edited a comment on pull request #13423:
URL: https://github.com/apache/airflow/pull/13423#issuecomment-753533840


   **one material change**
   
   in latest commit i made I made it so BashHook's run_command will use `os.environ` if `env` not supplied (and will _not_ use `os.environ` otherwise)
   
   **added / updated tests**
   
   i left all but one BashOperator test untouched.  only this one -- checking the args applied to Popen -- i moved to BashHook.
   
   where appropriate, i translated the existing tests for BashHook and copied them there.
   
   i will remove WIP designation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org