You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/11 01:56:32 UTC

[GitHub] [incubator-mxnet] barry-jin opened a new pull request #20006: [WIP][FFI] Adopt PackedFunc on Numpy Imperative Invoke

barry-jin opened a new pull request #20006:
URL: https://github.com/apache/incubator-mxnet/pull/20006


   ## Description ##
   Adopt PackedFunc based FFI on imperative invoke to reduce overhead. 
   
   ## Checklist ##
   ### Essentials ###
   - [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] barry-jin commented on pull request #20006: [FFI] Adopt PackedFunc on Numpy Imperative Invoke

Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20006:
URL: https://github.com/apache/incubator-mxnet/pull/20006#issuecomment-815119093


   > > Adopt PackedFunc based FFI on imperative invoke to reduce overhead.
   > 
   > Have you measured the improvement for this PR? Previously I thought you intend to convert the remaining operators to the new FFI, rendering the generic imperative invoke unneeded?
   
   Yes, some operators that takes no stringified params as invocation input will benefit a bit from it. 
   copyto
   ```python
   setup = """
   from mxnet import np, npx
   npx.set_np()
   a = np.zeros((2,2))
   b = np.ones((2,2))
   """
   stmt = """
   c = a.copyto(b)
   """
   timer = timeit.Timer(setup=setup,
                        stmt=stmt)
   num_repeat = 1000
   print(min(timer.repeat(repeat=10, number=num_repeat)) / num_repeat)
   
   legacy
   5.821948400000032e-05
   New FFI
   5.494140500000011e-05
   ```
   
   npx.gather_nd
   ```python
   setup = """
   from mxnet import np, npx
   npx.set_np()
   a = np.zeros((2,2))
   b = np.ones((2,2))
   """
   stmt = """
   c = npx.gather_nd(a, b)
   """
   timer = timeit.Timer(setup=setup,
                        stmt=stmt)
   num_repeat = 1000
   print(min(timer.repeat(repeat=10, number=num_repeat)) / num_repeat)
   
   legacy
   8.739984900000009e-05
   New FFI
   7.992273099999991e-05
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] barry-jin commented on pull request #20006: [FFI] Adopt PackedFunc on Numpy Imperative Invoke

Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20006:
URL: https://github.com/apache/incubator-mxnet/pull/20006#issuecomment-814532630


   @mxnet-bot run ci [all]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on pull request #20006: [FFI] Adopt PackedFunc on Numpy Imperative Invoke

Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20006:
URL: https://github.com/apache/incubator-mxnet/pull/20006#issuecomment-815090804


   Do you know why your PR has no coverage? https://app.codecov.io/gh/apache/incubator-mxnet/pulls/20006
   
   "Missing base report. Unable to compare commits because the base of the pull request did not upload a coverage report."
   
   I think there's a general issue with the codecov for master branch https://app.codecov.io/gh/apache/incubator-mxnet/pulls?page=1&state=open&order=-pullid
   Should we fix it first to ensure the current PR has good coverage?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] barry-jin closed pull request #20006: [FFI] Adopt PackedFunc on Numpy Imperative Invoke

Posted by GitBox <gi...@apache.org>.
barry-jin closed pull request #20006:
URL: https://github.com/apache/incubator-mxnet/pull/20006


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20006: [FFI] Adopt PackedFunc on Numpy Imperative Invoke

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20006:
URL: https://github.com/apache/incubator-mxnet/pull/20006#issuecomment-814532675


   Jenkins CI successfully triggered : [centos-cpu, miscellaneous, centos-gpu, windows-gpu, unix-gpu, sanity, clang, edge, website, windows-cpu, unix-cpu]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] barry-jin closed pull request #20006: [FFI] Adopt PackedFunc on Numpy Imperative Invoke

Posted by GitBox <gi...@apache.org>.
barry-jin closed pull request #20006:
URL: https://github.com/apache/incubator-mxnet/pull/20006


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu removed a comment on pull request #20006: [FFI] Adopt PackedFunc on Numpy Imperative Invoke

Posted by GitBox <gi...@apache.org>.
leezu removed a comment on pull request #20006:
URL: https://github.com/apache/incubator-mxnet/pull/20006#issuecomment-815090804


   Do you know why your PR has no coverage? https://app.codecov.io/gh/apache/incubator-mxnet/pulls/20006
   
   "Missing base report. Unable to compare commits because the base of the pull request did not upload a coverage report."
   
   I think there's a general issue with the codecov for master branch https://app.codecov.io/gh/apache/incubator-mxnet/pulls?page=1&state=open&order=-pullid
   Should we fix it first to ensure the current PR has good coverage?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20006: [WIP][FFI] Adopt PackedFunc on Numpy Imperative Invoke

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20006:
URL: https://github.com/apache/incubator-mxnet/pull/20006#issuecomment-796367534


   Hey @barry-jin , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-gpu, centos-cpu, unix-cpu, clang, miscellaneous, website, centos-gpu, sanity, windows-cpu, unix-gpu, edge]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu commented on pull request #20006: [FFI] Adopt PackedFunc on Numpy Imperative Invoke

Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #20006:
URL: https://github.com/apache/incubator-mxnet/pull/20006#issuecomment-815091885


   > Adopt PackedFunc based FFI on imperative invoke to reduce overhead.
   
   Have you measured the improvement for this PR? Previously I thought you intend to convert the remaining operators to the new FFI, rendering the generic imperative invoke unneeded?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org