You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2014/03/27 00:54:50 UTC
Re: Review Request 17817: OOZIE-1689 HA support for OOZIE-7(Ability to view
the log information corresponding to particular coordinator action)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17817/#review38679
-----------------------------------------------------------
minor comments. +1 after addressing them
core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java
<https://reviews.apache.org/r/17817/#comment70950>
Why is params map value data structure string array if we do not support multi values right now? can be added later if such design is added.
core/src/main/java/org/apache/oozie/util/AuthUrlClient.java
<https://reviews.apache.org/r/17817/#comment70951>
change to more meaningful name such as getQueryParamString()
- Mona Chitnis
On Feb. 13, 2014, 12:32 a.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17817/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2014, 12:32 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1689
> https://issues.apache.org/jira/browse/OOZIE-1689
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> HA support for OOZIE-7(Ability to view the log information corresponding to particular coordinator action)
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 8dc8b4b
> core/src/main/java/org/apache/oozie/util/AuthUrlClient.java 79f8883
> core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 29bca41
>
> Diff: https://reviews.apache.org/r/17817/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>