You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@htrace.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2015/04/30 20:26:07 UTC
[jira] [Comment Edited] (HTRACE-159) libhtrace.so: use HRPC
endpoint of htraced
[ https://issues.apache.org/jira/browse/HTRACE-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14521139#comment-14521139 ]
Colin Patrick McCabe edited comment on HTRACE-159 at 4/30/15 6:25 PM:
----------------------------------------------------------------------
Thanks for working on this, [~cmccabe].
I'm +1. I got spans on htraced Web-UI properly with the test code built against libhtrace.so. The following nit could be fixed before committing.
---
The code commented out should be removed if we don't use it later.
{noformat}
106 // {
107 // buf := make([]byte, cdc.length)
108 // _, err2 := io.ReadFull(cdc.conn, buf)
109 // if err2 != nil {
110 // return createErrAndLog(cdc.lg, "couldn't ReadFull")
111 // }
112 // cdc.lg.Infof("WATERMELON: read %s\n", string(buf))
114 // }
{noformat}
was (Author: iwasakims):
Thanks for working on this, [~cmccabe].
I'm +1. I got spans on htraced Web-UI properly with the test code built against libhtrace.so. The following nit could be fixed before committing.
---
The code commented out should be removed if we don't use it later.
{noformat}
106 // {
107 // buf := make([]byte, cdc.length)
108 // _, err2 := io.ReadFull(cdc.conn, buf)
109 // if err2 != nil {
110 // return createErrAndLog(cdc.lg, "couldn't ReadFull")
111 // }
112 // cdc.lg.Infof("WATERMELON: read %s\n", string(buf))
113 // return errors.New("YOU LOSE BITCH")
114 // }
{noformat}
> libhtrace.so: use HRPC endpoint of htraced
> ------------------------------------------
>
> Key: HTRACE-159
> URL: https://issues.apache.org/jira/browse/HTRACE-159
> Project: HTrace
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-159.001.patch, HTRACE-159.002.patch
>
>
> libhtrace.so (the htrace C client) should use the HRPC endpoint of htraced. This will be more efficient and also avoid unnecessary native dependencies.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)