You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2026/05/29 21:56:13 UTC
[PR] Codegen fix [pekko-grpc]
pjfanning opened a new pull request, #713:
URL: https://github.com/apache/pekko-grpc/pull/713
* CI build 'nightly' is failing since #677
* this is a band aid but I'm hoping it will allow us to get some testing of the sbt 2 plugin support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Codegen fix [pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #713:
URL: https://github.com/apache/pekko-grpc/pull/713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Codegen fix [pekko-grpc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #713:
URL: https://github.com/apache/pekko-grpc/pull/713#discussion_r3327105376
##########
codegen/src/main/scala/org/apache/pekko/grpc/gen/Main.scala:
##########
@@ -16,12 +16,15 @@ package org.apache.pekko.grpc.gen
import java.io.ByteArrayOutputStream
import java.net.URLDecoder
+import scala.annotation.nowarn
+
import com.google.protobuf.compiler.PluginProtos.CodeGeneratorRequest
import org.apache.pekko
import pekko.grpc.gen.javadsl.{ JavaClientCodeGenerator, JavaInterfaceCodeGenerator, JavaServerCodeGenerator }
import pekko.grpc.gen.scaladsl.{ ScalaClientCodeGenerator, ScalaServerCodeGenerator, ScalaTraitCodeGenerator }
// This is the protoc plugin that the gradle plugin uses
+@nowarn("msg=deprecated")
Review Comment:
this code needs to compile with Scala 3.8 now (sbt 2 plugins needs Scala 3.8+)
but also needs to compile in Scala 2.12
code compiles in Scala 3.8 but 'extends App' is now deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org