You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2023/02/07 11:29:57 UTC
[GitHub] [yunikorn-k8shim] zhuqi-lucas opened a new pull request, #523: YUNIKORN-1564 Constants for node attributes are not consistent in scheduler interface and shim
zhuqi-lucas opened a new pull request, #523:
URL: https://github.com/apache/yunikorn-k8shim/pull/523
### What is this PR for?
Before we do more changes to remove nodename noderack, and then add noderack to nodeinfo, also change in Scheduler Interface and webapp in https://issues.apache.org/jira/browse/YUNIKORN-1560
We first fix the consistence with interface and shim, then i will do above things.
And don't change the nodelabels field, because we will address new nodelabels pass instead of the json now in another jira:
https://issues.apache.org/jira/browse/YUNIKORN-1550
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1564
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #523: YUNIKORN-1564 Constants for node attributes are not consistent in scheduler interface and shim
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #523:
URL: https://github.com/apache/yunikorn-k8shim/pull/523#issuecomment-1441849073
This change is not needed, [YUNIKORN-1560](https://issues.apache.org/jira/browse/YUNIKORN-1560) will handle this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #523: YUNIKORN-1564 Constants for node attributes are not consistent in scheduler interface and shim
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on PR #523:
URL: https://github.com/apache/yunikorn-k8shim/pull/523#issuecomment-1427203880
See the comment in [YUNIKORN-1560](https://issues.apache.org/jira/browse/YUNIKORN-1560?focusedCommentId=17687660&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17687660) I don't think this is needed as it will be overwritten by that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #523: YUNIKORN-1564 Constants for node attributes are not consistent in scheduler interface and shim
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #523: YUNIKORN-1564 Constants for node attributes are not consistent in scheduler interface and shim
URL: https://github.com/apache/yunikorn-k8shim/pull/523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org