You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Carl-Eric Menzel (JIRA)" <ji...@apache.org> on 2016/11/25 15:20:59 UTC

[jira] [Created] (WICKET-6290) CssUrlReplacer doesn't understand data: urls and breaks them

Carl-Eric Menzel created WICKET-6290:
----------------------------------------

             Summary: CssUrlReplacer doesn't understand data: urls and breaks them
                 Key: WICKET-6290
                 URL: https://issues.apache.org/jira/browse/WICKET-6290
             Project: Wicket
          Issue Type: Bug
    Affects Versions: 1.5.17, 7.5.0, 6.25.0, 8.0.0-M2
            Reporter: Carl-Eric Menzel
            Assignee: Carl-Eric Menzel


CssUrlReplacer tries to replace data: urls that are used to embed base64-encoded small images directly in CSS files. This leads to the following:

{code}
Expected :.class {background-image: url(data:image/gif;base64,R0lGODlhEAAQAMQAAORHH);}
Actual   :.class {background-image: url('./wicket/resource/org.apache.wicket.resource.CssUrlReplacerTest/res/css/data:image/gif;base64,R0lGODlhEAAQAMQAAORHH--decorated');}
{code}

It should really just leave those URLs alone. I'll prepare a pull request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)