You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/02/22 08:18:29 UTC
[kudu-CR] [util] move PeriodWebUIChecker into a separate header file
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15271
Change subject: [util] move PeriodWebUIChecker into a separate header file
......................................................................
[util] move PeriodWebUIChecker into a separate header file
This patch moves PeriodWebUIChecker into a separate header file.
A follow-up changelist will use its functionality in a test outside
of the integration-tests test set.
Change-Id: I2e6c8e0ebe9e5d03ddf010ea225414af5823becc
---
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/webserver-stress-itest.cc
A src/kudu/util/webui_checker.h
4 files changed, 161 insertions(+), 112 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/15271/1
--
To view, visit http://gerrit.cloudera.org:8080/15271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e6c8e0ebe9e5d03ddf010ea225414af5823becc
Gerrit-Change-Number: 15271
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] move PeriodWebUIChecker into a separate header file
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15271 )
Change subject: [util] move PeriodWebUIChecker into a separate header file
......................................................................
Patch Set 1:
(2 comments)
> (2 comments)
>
> Looks like the TSAN build failed because the Gradle daemon died
> unexpectedly. Please ask Hao and/or Andrew to debug it further.
Yup, I'm planning to bug them on Monday.
http://gerrit.cloudera.org:8080/#/c/15271/1/src/kudu/util/webui_checker.h
File src/kudu/util/webui_checker.h:
PS1:
> In a follow-up, could you move some of the logic into a new .cc file too?
Done
http://gerrit.cloudera.org:8080/#/c/15271/1/src/kudu/util/webui_checker.h@29
PS1, Line 29: #include "kudu/client/client.h"
> The dependencies on client and mini-cluster modules suggest that util/ isn'
Indeed.
In fact, many of these header files are not needed. I removed them. Eventually, what's left is the dependency on ExternalMiniCluster. I could be replaced with a couple of arrays containing HostPort elements for the bound web server addresses, but I think keeping that dependency and moving this under mini_cluster is good enough.
--
To view, visit http://gerrit.cloudera.org:8080/15271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e6c8e0ebe9e5d03ddf010ea225414af5823becc
Gerrit-Change-Number: 15271
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Feb 2020 07:15:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] move PeriodWebUIChecker into a separate header file
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15271 )
Change subject: [util] move PeriodWebUIChecker into a separate header file
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e6c8e0ebe9e5d03ddf010ea225414af5823becc
Gerrit-Change-Number: 15271
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Feb 2020 20:48:33 +0000
Gerrit-HasComments: No
[kudu-CR] [util] move PeriodWebUIChecker into a separate header file
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Volodymyr Verovkin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15271
to look at the new patch set (#2).
Change subject: [util] move PeriodWebUIChecker into a separate header file
......................................................................
[util] move PeriodWebUIChecker into a separate header file
This patch moves PeriodWebUIChecker into a separate header file.
A follow-up changelist will use its functionality in a test outside
of the integration-tests test set.
Change-Id: I2e6c8e0ebe9e5d03ddf010ea225414af5823becc
---
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/webserver-stress-itest.cc
M src/kudu/mini-cluster/CMakeLists.txt
A src/kudu/mini-cluster/webui_checker.cc
A src/kudu/mini-cluster/webui_checker.h
6 files changed, 205 insertions(+), 112 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/15271/2
--
To view, visit http://gerrit.cloudera.org:8080/15271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e6c8e0ebe9e5d03ddf010ea225414af5823becc
Gerrit-Change-Number: 15271
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [util] move PeriodWebUIChecker into a separate header file
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15271 )
Change subject: [util] move PeriodWebUIChecker into a separate header file
......................................................................
Patch Set 1:
(2 comments)
Looks like the TSAN build failed because the Gradle daemon died unexpectedly. Please ask Hao and/or Andrew to debug it further.
http://gerrit.cloudera.org:8080/#/c/15271/1/src/kudu/util/webui_checker.h
File src/kudu/util/webui_checker.h:
PS1:
In a follow-up, could you move some of the logic into a new .cc file too?
http://gerrit.cloudera.org:8080/#/c/15271/1/src/kudu/util/webui_checker.h@29
PS1, Line 29: #include "kudu/client/client.h"
The dependencies on client and mini-cluster modules suggest that util/ isn't a good place for this, or that there needs to be some additional decomposition.
--
To view, visit http://gerrit.cloudera.org:8080/15271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e6c8e0ebe9e5d03ddf010ea225414af5823becc
Gerrit-Change-Number: 15271
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Feb 2020 22:22:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] move PeriodWebUIChecker into a separate header file
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15271 )
Change subject: [util] move PeriodWebUIChecker into a separate header file
......................................................................
[util] move PeriodWebUIChecker into a separate header file
This patch moves PeriodWebUIChecker into a separate header file.
A follow-up changelist will use its functionality in a test outside
of the integration-tests test set.
Change-Id: I2e6c8e0ebe9e5d03ddf010ea225414af5823becc
Reviewed-on: http://gerrit.cloudera.org:8080/15271
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/linked_list-test.cc
M src/kudu/integration-tests/webserver-stress-itest.cc
M src/kudu/mini-cluster/CMakeLists.txt
A src/kudu/mini-cluster/webui_checker.cc
A src/kudu/mini-cluster/webui_checker.h
6 files changed, 205 insertions(+), 112 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15271
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e6c8e0ebe9e5d03ddf010ea225414af5823becc
Gerrit-Change-Number: 15271
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>