[GitHub] brodybits opened a new pull request #559: Ignore version file in eslint to resolve build error

[GitBox <gi...@apache.org>]

brodybits opened a new pull request #559: Ignore version file in eslint to resolve build error
URL: https://github.com/apache/cordova-android/pull/559
 
 
   This change should to give us a green build again.
   
   Rationale is that the eslint update introduced in 393dad6349d8df55d8fca7d3e5014f36dfa4610c checks most of the files under `bin` and will not accept JavaScript that uses double-quotes for strings. The workaround in 393dad6349d8df55d8fca7d3e5014f36dfa4610c was to change the generated `bin/templates/cordova/version` file to use single-quotes in the version string.
   
   But since cordova-coho will regenerate `bin/templates/cordova/version` with double-quotes when updating the version number, we need a different solution.
   
   This is a quick workaround solution. I won't have a problem if anyone wants to propose an improved solution. Alternative may be to update cordova-coho to generate version file with single-quotes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org