You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "essobedo (via GitHub)" <gi...@apache.org> on 2023/06/15 07:22:29 UTC

[GitHub] [camel-quarkus] essobedo opened a new pull request, #4992: Ref #4220: Upgrade to SRU2022-10.0.1

essobedo opened a new pull request, #4992:
URL: https://github.com/apache/camel-quarkus/pull/4992

   fixes #4220 (part 2)
   
   ## Motivation
   
   After migrating to Upgrade to SRU2022-10.0.0, some tests failed due to [a reflection issue when serializing the MX messages in JSON ](https://github.com/prowide/prowide-iso20022/pull/83#issuecomment-1580150900).
   
   ## Modifications
   
   * Removes the temporary workaround


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-quarkus] essobedo commented on pull request #4992: Ref #4220: Upgrade to SRU2022-10.0.1

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #4992:
URL: https://github.com/apache/camel-quarkus/pull/4992#issuecomment-1593342573

   @JiriOndrusek Could you please avoid to force push in a shared branch like `camel-main`? Thank you in advance 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-quarkus] essobedo commented on pull request #4992: Ref #4220: Upgrade to SRU2022-10.0.1

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #4992:
URL: https://github.com/apache/camel-quarkus/pull/4992#issuecomment-1594259780

   Actually, you should only push your new commits no need to force them.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-quarkus] essobedo commented on pull request #4992: Ref #4220: Upgrade to SRU2022-10.0.1

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #4992:
URL: https://github.com/apache/camel-quarkus/pull/4992#issuecomment-1594296837

   If it is clear to you now, that's good news, otherwise don't hesitate to reach out to me on Zulip


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4992: Ref #4220: Upgrade to SRU2022-10.0.1

Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4992:
URL: https://github.com/apache/camel-quarkus/pull/4992#issuecomment-1594284924

   Oh, I can do that, sorry for doing it wrong. I might miss-understand use of `git push --force-with-lease` for maintenance. Thanks for telling me! 
   
   But 
   
   I just checked again `git push --force-with-lease`. It's like a normal push, which pushes only in case, that the there is no new commit in the repo.
   (I'm using it to ensure that I do not overwrite any commit which was merged/pushed in meantime)
   Therefore if I push with force-with-lease something it behaves similarly to `push` alone. If I yesterday pushed the change, the problem would be the same, right?
   In other words If I'd have used `git push` the yesterday, the result would be the same from you POV, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4992: Ref #4220: Upgrade to SRU2022-10.0.1

Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4992:
URL: https://github.com/apache/camel-quarkus/pull/4992#issuecomment-1594290920

   Perhaps my problem yesterday was, that I forgot to push in the morning and did it later that day.
   
   Sorry for discussing this topic in so many comments. I'm trying understand what to do correctly and why.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-quarkus] essobedo commented on pull request #4992: Ref #4220: Upgrade to SRU2022-10.0.1

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on PR #4992:
URL: https://github.com/apache/camel-quarkus/pull/4992#issuecomment-1592501478

   Depends on https://github.com/apache/camel/pull/10398


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-quarkus] essobedo merged pull request #4992: Ref #4220: Upgrade to SRU2022-10.0.1

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo merged PR #4992:
URL: https://github.com/apache/camel-quarkus/pull/4992


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4992: Ref #4220: Upgrade to SRU2022-10.0.1

Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4992:
URL: https://github.com/apache/camel-quarkus/pull/4992#issuecomment-1594176057

   @essobedo Hi, I used `git push --force-with-lease`, which is recommended procedure for maintenance of `camel-main`. I'm very sorry that I missed your PR and sorry for any inconvenience it caused to you. Usually after `git push --force-with-lease` I should comment all existing PRs and point out with a comment, that this is happening and rebase is needed.
   (I'm usually pushing changes each day in case the build of `camel-main` fails with the recent changes in Camel) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org