[jira] [Commented] (ARTEMIS-1018) Duplicate error ids on different error messages

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636084#comment-16636084 ] 

ASF GitHub Bot commented on ARTEMIS-1018:
-----------------------------------------

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2340

    ARTEMIS-1018 de-duplicate logging codes

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1018

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2340
    
----
commit f706fead0df06f528220f7ed3793639f03124066
Author: Justin Bertram <jb...@...>
Date:   2018-10-02T20:31:23Z

    ARTEMIS-1018 de-duplicate logging codes

----


> Duplicate error ids on different error messages
> -----------------------------------------------
>
>                 Key: ARTEMIS-1018
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1018
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.0.0
>            Reporter: Jiri Daněk
>            Priority: Minor
>
> Some messages happen to have the same id, for example
> {noformat}
>    @Message(id = 119019, value = "Session is closed")
>    ActiveMQObjectClosedException sessionClosed();
>   @Message(id = 119019, value = "Queue already exists {0}", format = Message.Format.MESSAGE_FORMAT)
>    ActiveMQQueueExistsException queueAlreadyExists(SimpleString queueName);
> {noformat}
> (I stumbled upon this when trying to send message from artemis-jms-client-1.5.4 to artemis-server-2.0.0; I searched for the message code of the message I got and got two results, instead of one.)
> It may not be a problem, since one is ActiveMQClientMessageBundle and the other is ActiveMQMessage bundle, but still.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)