You are viewing a plain text version of this content. The canonical link for it is here.
Posted to olio-commits@incubator.apache.org by sh...@apache.org on 2009/11/13 00:32:57 UTC

svn commit: r835668 - /incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java

Author: sheetal
Date: Fri Nov 13 00:32:57 2009
New Revision: 835668

URL: http://svn.apache.org/viewvc?rev=835668&view=rev
Log:
OLIO-135 ServletResponse flushBuffer() caused the response to commit.

Modified:
    incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java

Modified: incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java
URL: http://svn.apache.org/viewvc/incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java?rev=835668&r1=835667&r2=835668&view=diff
==============================================================================
--- incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java (original)
+++ incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java Fri Nov 13 00:32:57 2009
@@ -88,11 +88,11 @@
    
 
     @Override public void setBufferSize(int i) {
-        System.err.println("setBufferSize(int i) called.");
+        //System.err.println("setBufferSize(int i) called.");
     }
 
     @Override public void flushBuffer() throws IOException {
-        System.err.println("flushBuffer() called.");
+        //System.err.println("flushBuffer() called.");
         stream.flush();
     }
   



Re: svn commit: r835668 - /incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java

Posted by Sheetal Patil <Sh...@Sun.COM>.
No, I have not tested the fix for glassfish.
But, I think it should not cause any problem on glassfish.

Thanks and Regards,
Sheetal

On 11/13/09 08:58, Shanti Subramanyam wrote:
> Sheetal,
> Did you check this fix against glassfish ?
>
> Shanti
>
> sheetal@apache.org wrote:
>> Author: sheetal
>> Date: Fri Nov 13 00:32:57 2009
>> New Revision: 835668
>>
>> URL: http://svn.apache.org/viewvc?rev=835668&view=rev
>> Log:
>> OLIO-135 ServletResponse flushBuffer() caused the response to commit.
>>
>> Modified:
>>     
>> incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java 
>>
>>
>> Modified: 
>> incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java 
>>
>> URL: 
>> http://svn.apache.org/viewvc/incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java?rev=835668&r1=835667&r2=835668&view=diff 
>>
>> ============================================================================== 
>>
>> --- 
>> incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java 
>> (original)
>> +++ 
>> incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java 
>> Fri Nov 13 00:32:57 2009
>> @@ -88,11 +88,11 @@
>>      
>>      @Override public void setBufferSize(int i) {
>> -        System.err.println("setBufferSize(int i) called.");
>> +        //System.err.println("setBufferSize(int i) called.");
>>      }
>>  
>>      @Override public void flushBuffer() throws IOException {
>> -        System.err.println("flushBuffer() called.");
>> +        //System.err.println("flushBuffer() called.");
>>          stream.flush();
>>      }
>>   
>>
>>   


Re: svn commit: r835668 - /incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java

Posted by Shanti Subramanyam <Sh...@Sun.COM>.
Sheetal,
 Did you check this fix against glassfish ?

Shanti

sheetal@apache.org wrote:
> Author: sheetal
> Date: Fri Nov 13 00:32:57 2009
> New Revision: 835668
>
> URL: http://svn.apache.org/viewvc?rev=835668&view=rev
> Log:
> OLIO-135 ServletResponse flushBuffer() caused the response to commit.
>
> Modified:
>     incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java
>
> Modified: incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java
> URL: http://svn.apache.org/viewvc/incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java?rev=835668&r1=835667&r2=835668&view=diff
> ==============================================================================
> --- incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java (original)
> +++ incubator/olio/webapp/java/trunk/ws/apps/webapp/src/java/org/apache/olio/webapp/util/ContentCacheResponseWrapper.java Fri Nov 13 00:32:57 2009
> @@ -88,11 +88,11 @@
>     
>  
>      @Override public void setBufferSize(int i) {
> -        System.err.println("setBufferSize(int i) called.");
> +        //System.err.println("setBufferSize(int i) called.");
>      }
>  
>      @Override public void flushBuffer() throws IOException {
> -        System.err.println("flushBuffer() called.");
> +        //System.err.println("flushBuffer() called.");
>          stream.flush();
>      }
>    
>
>
>