You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/09 11:54:49 UTC
[GitHub] [flink] twalthr opened a new pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
twalthr opened a new pull request #17217:
URL: https://github.com/apache/flink/pull/17217
## What is the purpose of the change
Reduces friction by not throwing an exception for multi-rowtime queries for `collect()` and `print()`.
## Verifying this change
This change added tests and can be verified as follows: `TableITCase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988",
"triggerID" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 578e56afa1aaa77e228151f13eba81ededa2b3d0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916021405
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9dabc5a8861ded66340ae99566a93e64c42dca01 (Thu Sep 09 11:57:07 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988",
"triggerID" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894",
"triggerID" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 476e4fde0e55c161f40e86eae166022f1a6803db Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988",
"triggerID" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"triggerType" : "PUSH"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894",
"triggerID" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
}, {
"hash" : "7390bb747f485bef4cde1925f885784b2bc227ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "990745078",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "990745078",
"triggerType" : "MANUAL"
}, {
"hash" : "7390bb747f485bef4cde1925f885784b2bc227ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7390bb747f485bef4cde1925f885784b2bc227ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 7390bb747f485bef4cde1925f885784b2bc227ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988",
"triggerID" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"triggerType" : "PUSH"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894",
"triggerID" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 476e4fde0e55c161f40e86eae166022f1a6803db Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988",
"triggerID" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 578e56afa1aaa77e228151f13eba81ededa2b3d0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 637c37904be8ebb0409b2fe37beead74882ca811 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080)
* 578e56afa1aaa77e228151f13eba81ededa2b3d0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dabc5a8861ded66340ae99566a93e64c42dca01 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988",
"triggerID" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"triggerType" : "PUSH"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894",
"triggerID" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "990745078",
"triggerType" : "MANUAL"
}, {
"hash" : "7390bb747f485bef4cde1925f885784b2bc227ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27938",
"triggerID" : "990745078",
"triggerType" : "MANUAL"
}, {
"hash" : "7390bb747f485bef4cde1925f885784b2bc227ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27938",
"triggerID" : "7390bb747f485bef4cde1925f885784b2bc227ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 7390bb747f485bef4cde1925f885784b2bc227ac Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27938)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-989926212
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 637c37904be8ebb0409b2fe37beead74882ca811 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047923
@MartijnVisser the query is still correct. I was planning to merge this only to master, so we could revert you change only there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988",
"triggerID" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"triggerType" : "PUSH"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 476e4fde0e55c161f40e86eae166022f1a6803db UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988",
"triggerID" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"triggerType" : "PUSH"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
}, {
"hash" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27894",
"triggerID" : "476e4fde0e55c161f40e86eae166022f1a6803db",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "989926212",
"triggerType" : "MANUAL"
}, {
"hash" : "7390bb747f485bef4cde1925f885784b2bc227ac",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27938",
"triggerID" : "990745078",
"triggerType" : "MANUAL"
}, {
"hash" : "7390bb747f485bef4cde1925f885784b2bc227ac",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27938",
"triggerID" : "7390bb747f485bef4cde1925f885784b2bc227ac",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "990745078",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 7390bb747f485bef4cde1925f885784b2bc227ac Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27938)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #17217:
URL: https://github.com/apache/flink/pull/17217#discussion_r705283784
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecSink.java
##########
@@ -120,13 +121,16 @@ public StreamExecSink(
rowtimeFieldIndices.add(i);
}
}
+
+ final boolean isCollectSink = tableSinkSpec.getTableSink() instanceof CollectDynamicSink;
Review comment:
Wouldn't it be "cleaner" if an `isCollectSink()` method (or simply`isCollect()`) is introduced to the iface?
Or alternatively, if the method is implemented in a utility class in that package, so that changing the class to `public` just for the purpose of `instanceof` call is avoided?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 637c37904be8ebb0409b2fe37beead74882ca811 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988",
"triggerID" : "578e56afa1aaa77e228151f13eba81ededa2b3d0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 637c37904be8ebb0409b2fe37beead74882ca811 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080)
* 578e56afa1aaa77e228151f13eba81ededa2b3d0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24988)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dabc5a8861ded66340ae99566a93e64c42dca01 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #17217:
URL: https://github.com/apache/flink/pull/17217#discussion_r705303998
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecSink.java
##########
@@ -120,13 +121,16 @@ public StreamExecSink(
rowtimeFieldIndices.add(i);
}
}
+
+ final boolean isCollectSink = tableSinkSpec.getTableSink() instanceof CollectDynamicSink;
Review comment:
> Wouldn't it be "cleaner" if an isCollectSink() method (or simplyisCollect()) is introduced to the iface?
`DynamicTableSink` is a public API, so we'd be throwing a method into it for internal purposes. Such a method also breaks the abstraction, because you're asking the interface for whether it is a specific implementation.
> Or alternatively, if the method is implemented in a utility class in that package, so that changing the class to public just for the purpose of instanceof call is avoided?
Then you'd just have to make that utility public instead, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 637c37904be8ebb0409b2fe37beead74882ca811 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-990745078
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-919219613
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 637c37904be8ebb0409b2fe37beead74882ca811 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "919219613",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 637c37904be8ebb0409b2fe37beead74882ca811 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24095) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17217:
URL: https://github.com/apache/flink/pull/17217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #17217:
URL: https://github.com/apache/flink/pull/17217#discussion_r705384003
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecSink.java
##########
@@ -120,13 +121,16 @@ public StreamExecSink(
rowtimeFieldIndices.add(i);
}
}
+
+ final boolean isCollectSink = tableSinkSpec.getTableSink() instanceof CollectDynamicSink;
Review comment:
> `DynamicTableSink` is a public API, so we'd be throwing a method into it for internal purposes. Such a method also breaks the abstraction, because you're asking the interface for whether it is a specific implementation.
True, thx!
> Then you'd just have to make that utility public instead, no?
Yep, not insisting, just to me seems a bit cleaner than exposing the class as public just to enable the `instanceof` call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dabc5a8861ded66340ae99566a93e64c42dca01 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851)
* 637c37904be8ebb0409b2fe37beead74882ca811 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
}, {
"hash" : "637c37904be8ebb0409b2fe37beead74882ca811",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080",
"triggerID" : "637c37904be8ebb0409b2fe37beead74882ca811",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dabc5a8861ded66340ae99566a93e64c42dca01 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23851)
* 637c37904be8ebb0409b2fe37beead74882ca811 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24080)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047672
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9dabc5a8861ded66340ae99566a93e64c42dca01",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dabc5a8861ded66340ae99566a93e64c42dca01 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr edited a comment on pull request #17217: [FLINK-24186][table-planner] Allow multiple rowtime attributes for collect() and print()
Posted by GitBox <gi...@apache.org>.
twalthr edited a comment on pull request #17217:
URL: https://github.com/apache/flink/pull/17217#issuecomment-916047923
@MartijnVisser the documented query is still correct. I was planning to merge this only to master, so we could revert you change only there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org