[PR] arch/x86_64: Fix up_timer_start. [nuttx]

["Fix-Point (via GitHub)" <gi...@apache.org>]

Fix-Point opened a new pull request, #14045:
URL: https://github.com/apache/nuttx/pull/14045

   ## Summary
   This commit fixed up_timer.
   
   ## Impact
   x86_64 up_timer.
   
   ## Testing
   Tested on x86_64 qemu/kvm.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arch/x86_64: Fix up_timer_start. [nuttx]

["raiden00pl (via GitHub)" <gi...@apache.org>]

raiden00pl merged PR #14045:
URL: https://github.com/apache/nuttx/pull/14045


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arch/x86_64: Fix up_timer_start. [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #14045:
URL: https://github.com/apache/nuttx/pull/14045#issuecomment-2404841361

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   **No, this PR does not meet the NuttX requirements.**
   
   **Missing Information:**
   
   * **Summary:** 
       *  Lacks a clear explanation of why the change to `up_timer` was necessary. Was it a bug fix, performance improvement, or something else? 
       *  Needs to describe how the `up_timer` was fixed. What was the problem and what was the solution?
   * **Impact:**
       * Simply stating "x86_64 up_timer" is not descriptive enough.  
       * Specify if any existing functionality changed due to the fix.
       * Address all other impact points (build, hardware, documentation, security, compatibility). Even if the answer is "NO," state it explicitly.
   * **Testing:**
       * Provide more context about your testing environment (specific OS, QEMU version, etc.).
       * Include relevant snippets of the testing logs that demonstrate the problem before the fix and the successful outcome after the fix. 
   
   **Recommendations:**
   
   1. **Expand the Summary:** Clearly articulate the problem the commit addresses and provide a concise overview of the solution implemented.
   2. **Detail the Impact:**  Be specific about how the change affects the system. If there's no impact on a particular area (like documentation), explicitly state "NO."
   3. **Provide Meaningful Testing Logs:** Include excerpts from your logs that highlight the issue before the fix and the improvement after.  Make it easy for reviewers to understand what you tested and how. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org